[Bluetooth][Certification] TC_TG_CEC_BV_02_I failed

VERIFIED FIXED in Firefox 28, Firefox OS v1.2

Status

Firefox OS
Bluetooth
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ypwalter, Assigned: gyeh)

Tracking

unspecified
1.3 Sprint 6 - 12/6
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, firefox26 wontfix, firefox27 wontfix, firefox28 fixed, b2g-v1.2 fixed)

Details

Attachments

(5 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 8339074 [details]
CEC.zip

log attached
(Reporter)

Updated

4 years ago
Blocks: 939706
Nominate as koi+ since it blocks v1.2 Bluetooth certification. Ben is taking a first look.
Assignee: nobody → btian
blocking-b2g: --- → koi?

Comment 2

4 years ago
The bug results from incomplete CoD logic in ProfileController. This AVRCP test case fails as ProfileController doesn't connect to AVRCP based on PTS CoD 0x20050c but regards it as a peripheral device for HID.

Gina will revise ProfileController CoD logic.
Assignee: btian → gyeh
Triage: This will block AVRCP Bluetooth certification blocker. 1.2+
blocking-b2g: koi? → koi+
(Assignee)

Comment 4

4 years ago
Created attachment 8342255 [details] [diff] [review]
Patch 1(v1): Refine the logic for checking AVRCP and HID

The patch is coming. Please help to review. Thanks.
Attachment #8342255 - Flags: review?(echou)
(Assignee)

Comment 5

4 years ago
I've tested the patch with PTS. The test case is passed. :)
Comment on attachment 8342255 [details] [diff] [review]
Patch 1(v1): Refine the logic for checking AVRCP and HID

Review of attachment 8342255 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Thanks.

::: dom/bluetooth/BluetoothProfileController.h
@@ +46,5 @@
> +// Remote Control: sub-field of minor device class, Bit 5 ~ Bit 2 = 0x3
> +#define IS_REMOTE_CONTROL(cod)       ((GET_MINOR_DEVICE_CLASS(cod) & 0xf) == 0x3)
> +
> +// Keyboard/Pointing: sub-field of minor device class, Bit 6/7 is set
> +#define NON_KEYBOARD_NON_POINTING(cod)  (!(GET_MINOR_DEVICE_CLASS(cod) & 0x30))

Per offline discussion with Gina, she will split this into two macros IS_KEYBOARD and IS_POINTING_DEVICE because it seems to be more readable.
Attachment #8342255 - Flags: review?(echou) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 8342283 [details] [diff] [review]
[Final] Refine BluetoothProfileController logic for AVRCP and HID, r=echou

https://tbpl.mozilla.org/?tree=Try&rev=c2956ad3979b
Attachment #8342255 - Attachment is obsolete: true
(Assignee)

Comment 8

4 years ago
Created attachment 8342286 [details] [diff] [review]
[v1.2] Refine BluetoothProfileController logic for AVRCP and HID, r=echou, a=koi+

Patch for branch v1.2
(Assignee)

Comment 9

4 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/e8970388942a
https://hg.mozilla.org/mozilla-central/rev/e8970388942a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8028ac69a00e
status-b2g-v1.2: --- → fixed
status-firefox26: --- → wontfix
status-firefox27: --- → wontfix
status-firefox28: --- → fixed
Target Milestone: --- → 1.3 Sprint 6 - 12/6
(Assignee)

Comment 12

4 years ago
Per Ben Tian, there's something different between v1.2 and master for OPP. The major difference is that we still need to call Connect() before calling SendFile(). Therefore, I have to re-open this bug unfortunately and create one more patch for v1.2.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 13

4 years ago
I'll attach patch 2 for v1.2 soon.
(Assignee)

Comment 14

4 years ago
Created attachment 8343473 [details] [diff] [review]
[v1.2] Revert the changes for BluetoothOppManager

Hi Eric,

I'd like to send a review request to you. Please help to check. Thanks.
Attachment #8343473 - Flags: review?(echou)
Comment on attachment 8343473 [details] [diff] [review]
[v1.2] Revert the changes for BluetoothOppManager

Review of attachment 8343473 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Please double confirm file transfer via BT working well on v1.2 after this patch applied.
Attachment #8343473 - Flags: review?(echou) → review+
(Assignee)

Comment 16

4 years ago
Created attachment 8343609 [details] [diff] [review]
[v1.2] Revert the changes for BluetoothOppManager, r=echou, a=koi+
Attachment #8343473 - Attachment is obsolete: true
(Assignee)

Comment 17

4 years ago
Ryan, could you help to push this patch to branch v1.2? Thanks for your help.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
(Assignee)

Comment 18

4 years ago
(In reply to Eric Chou [:ericchou] [:echou] from comment #15)
> Comment on attachment 8343473 [details] [diff] [review]
> [v1.2] Revert the changes for BluetoothOppManager
> 
> Review of attachment 8343473 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM. Please double confirm file transfer via BT working well on v1.2 after
> this patch applied.

I tested on unagi. Both receiving files and sending files work well.
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/137d116ae04f
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Created attachment 8348566 [details]
Bug943752_Verification.zip
Verified with Bluetooth PTS 4.9

Gaia      fcf1c2fe020c29da4755621cbffdc1a333a43be9                           │  
Gecko     http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/129ad3c335a5 │  
BuildID   20131216004002                                                     │  
Version   26.0                                                               │  
ro.build.version.incremental=eng.archermind.20131114.105818                  │  
ro.build.date=Thu Nov 14 10:58:33 CST 2013
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.