Closed Bug 943776 Opened 12 years ago Closed 8 years ago

[email] Fix reply-all marionette test and re-enable once marionette tests support synthetic message injection (was: canForward removed, breaks canReplyAll checking/disabling)

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: asuth, Unassigned)

References

Details

During the review cycle for bug 802944 I requested that canForward be removed since it was moot. It was removed, but the use of it in onReplyMenu in message_reader.js was not removed, so the message reader prints an error like this when it builds its reply menu: ERR: onerror reporting: TypeError: this.canForward is not a function @ app://email.gaiamobile.org/js/cards/message_reader.js : 437 The only thing that breaks is disabling the reply all option from the reply list, which is not particularly a big deal, but we should fix it.
Okay, I fixed the bug in bug 837251, but then the reply-all marionette test is no good because the hack used to get e-mails into the inbox creates a situation where reply-all is not a valid option.
Summary: [email] canForward check needs to be removed from message_reader.js' onReplyMenu, breaks disabling reply-all button [TypeError: this.canForward is not a function] → [email] Fix reply-all marionette test and re-enable once marionette tests support synthetic message injection (was: canForward removed, breaks canReplyAll checking/disabling)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.