Closed Bug 943784 Opened 11 years ago Closed 11 years ago

[UITest][HW] remove 'var navigator = window.navigator' in radio test

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tjao, Assigned: tjao)

References

Details

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/14253
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review 
Apparently I forgot to handle this situation. Needs to be fix.
Assignee: nobody → tjao
Blocks: eng-mode
I found this problem is caused by 'navigator' and it should be replaced by 'window.navigator'
Summary: [UITest][HW] radio test fails if no SIM card is inserted → [UITest][HW] change navigator to window.navigator in radio test
This is stupid. Just forget about 'var navigator = window.navigator;'
Summary: [UITest][HW] change navigator to window.navigator in radio test → [UITest][HW] remove 'var navigator = window.navigator' in radio test

        Attachment #8340958 -
        Flags: review?(gasolin)

    
  

        Attachment #8340958 -
        Flags: review?(gasolin) → review+

    
    

    
  
Finally :)

merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/bece7cb20e790d0f562c45e2cb2b44b90e290ef6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: