[Settings] unsupported rule in apps.css

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Bug 818200 has added a `filter: drop-shadow' rule to the Settings CSS that is overwritten by an SVG filter rule. This generates a JS warning every time, let’s get rid of it please.
(Assignee)

Comment 1

4 years ago
Created attachment 8339141 [details] [review]
patch

https://github.com/mozilla-b2g/gaia/pull/14111
Assignee: nobody → kaze
Attachment #8339141 - Flags: review?(gasolin)

Comment 2

4 years ago
Comment on attachment 8339141 [details] [review]
patch

just checked MDN and gecko still not support drop-shadow filter, so we really not need that syntax.

https://developer.mozilla.org/en-US/docs/Web/CSS/filter?redirectlocale=en-US&redirectslug=CSS%2Ffilter#Gecko_notes

thanks!
Attachment #8339141 - Flags: review?(gasolin) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.