943807 - [TestAgent] Better UI for TestAgent app: search box and wrapping lines

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

It's hard to find a specific test now.
The lines won't wrap, and there're no way to search a specific test...

These should be fixed. IMO, these should be done:

1. Group by categories
2. Add a search box, to do a simple, regex based search (filter)
3. The lines should be wrapped

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

I've finished the search tool by 'window.find' API. The next thing is to group tests.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Tools & UI.png

Done. Paste a preview first.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Now you can

1. Search any single test
2. Search categories (by '#system' to search 'system' category)
3. Click on categories head to add all tests in the group or cancel them at once
4. See how many tests in the category
5. No more overlapped lines.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14636643

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8339687 [details] [review]
Patch

Greg, could you rebase to master and set me review flag again? test-agent was updated and conflict with your changes.

Comment 6

[Julien Wajsberg [:julienw]]

Hey, sorry about that ;)

I think I fixed the wrapping problem in bug 940969, but the other changes sound very cool!

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8339687 [details] [review]
Patch

I fixed the incompatible styles and pushed again.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14907688

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8339687 [details] [review]
Patch

it's a great improvement! r=yurenju if nits are addressed.

Comment 10

[Julien Wajsberg [:julienw]]

I am quite upset because:

* it has been merged and nothing has been written in this bug
* this regressed some of the style changes I did in bug 940969:
  - use the column CSS property to display columns on bigger screens
  - the style for selected elements is really bad now:
    * generated content is wrongly positioned
    * the color and text-decoration changes don't work
  - the style I did for the small screen version is bad as well

So the UI is currently very bad...

It's difficult to backout because a new version has been pushed, but you should really really (really) fix all this quickly.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

1. If you don't like my patch so deeply, I can just try my best to back-out it, and you can just say that straightforward, without those implicit disappearings.

2. And, yes, your patch is earlier than mine, and obviously you're very expert at responsible design,
so your styles are correct one, not mine. Even though my patch got broken by your styles, too.

3. Additionally, I just want to own a comfortable version of test agent, which is really really really (really) upset everyone to live with the old version so long in our daily life, and it seems that no one care about it during these months before you and me suddenly(?) take actions to fix it. So if you want to and should to take the responsibility, not like me to do this just unofficially, just take it, and I would never bother test-agent again. 

4. I tend to fix bugs after the major patch, include styles. Again, if this is not our style to develop the test-agent, a back-out would be the simplest way to make everybody happy.

5. I forgot go back here to mention that, its my fault, definitely.

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Julien, could you attach a screenshot for current test-agent which you have? last time I reviewed this PR I saw some features are really useful like check all test cases per app and search box.

maybe we just have some styles issues when merge this PR. if so, let's file an issue to fix it.

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: 螢幕截圖 2013-12-12 10.07.20.png

this is a screenshot which I just take.

Comment 14

[Julien Wajsberg [:julienw]]

Hey Greg, Yuren,

I just wanted to say that I'm sorry if my comment sounded rude. I am very happy that you contributed to this, and most of the changes are really good: the search box, the grouping per apps, etc.

What I blame here, is just that you probably resolved the conflict without trying to understand what the conflicted patch was doing, and as a result you reverted some of it. So while there is nothing we can't fix, what I really want is that if you encounter such a situation in the future, you react differently.

I'll file a new bug and show test-agent screenshots before and after this patch, it will make things easier.

Comment 15

[Julien Wajsberg [:julienw]]

Flagging me so that I file a new bug tomorrow.

Comment 16

[Julien Wajsberg [:julienw]]

Something else is wrong here: the test-agent upstream is [1]. The files that are in gaia are really copied from this from time to time (see [2]). That means your changes here will eventually be overwritten.

I filed bug 950083 and I'll try to apply your changes here to the existing test-agent codebase.

Now I'm closing this bug as fixed because it landed:
master: /ea885a8f11a4779c2443991511f353ae7ee7207c

[1] https://github.com/mozilla-b2g/js-test-agent
[2] https://github.com/mozilla-b2g/gaia/blob/master/Makefile#L731-L751