Closed
Bug 943813
Opened 11 years ago
Closed 11 years ago
[Gallery] scrollToShowThumbnail not work
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed)
People
(Reporter: gduan, Assigned: gduan)
Details
(Keywords: regression)
Attachments
(1 file)
scrollToShowThumbnail not work when switch from fullscreen.
Assignee | ||
Comment 1•11 years ago
|
||
Hi David, This patch has only updated one line, please kindly help to check. thanks.
Attachment #8339187 -
Flags: review?(dflanagan)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gduan
Comment 2•11 years ago
|
||
Comment on attachment 8339187 [details]
PR to master
Thanks for noticing and fixing this. I have not tested it but I assume that you have. We must have broken this when we landed the change to group photos by month.
I'm going to mark this as a regression and request 1.3+ on it.
Attachment #8339187 -
Flags: review?(dflanagan) → review+
Comment 3•11 years ago
|
||
This is a regression caused by a 1.3 feature, and it has a one-line fix so I think we should uplift to 1.3
blocking-b2g: --- → 1.3?
Keywords: regression
Assignee | ||
Comment 4•11 years ago
|
||
Hi David, I just rebased to latest code. I found that I need to add additional two lines as below in case the files is empty in the beginning. Would you mind to take a look again? if (!files[n]) return;
Flags: needinfo?(dflanagan)
Comment 6•11 years ago
|
||
George, It looks good to me. Thanks for finding and fixing this. Assuming you have tested to verify that it fixes the regression, please land it. I've set the status flag so it will be uplifted to 1.3. But feel free to manually uplift yourself, since I'm guessing the uplift won't happen until January otherwise.
status-b2g-v1.3:
--- → affected
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 7•11 years ago
|
||
Merge into master, https://github.com/mozilla-b2g/gaia/commit/a092cc587929caaa6dfd84116a0d5b91e5637a0d
Assignee | ||
Comment 8•11 years ago
|
||
Uplift to v1.3 https://github.com/mozilla-b2g/gaia/commit/ee5560ab86103701a5d046ef31d46e6c1e026355
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•