943818 - The app permission page displays the duplicate items if the same app is being installed multiple times with App Manager

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[William Hsu [:whsu]]

* Description:
  If you use app manager to repeatedly install a third party app, you will see the app permission page display the duplicate icon.
  Attaching the screenshot.

* Precondition:
  - Please use App Manager to connect FxOS device

* Reproduction steps:
  1. Use app manager to install a third party app repeatedly.
  2. Launch the app permission of settings app to check the installed apps.

* Expected result:
  No duplicate item displays on app permission page.

* Actual result:
  The app permission page displays the duplicate items

* Reproduction build:( Mozilla-aurora-hamachi-eng/2013-10-01-00-40-03)
  - Gaia:     5e0d0df6a762cf1e1812eeb735fba72e2539dc0c
  - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/5689e4237ab7
  - BuildID   20131001004003
  - Version   26.0a2

Comment 1

[William Hsu [:whsu]]

Attachment: Duplicate app name

Comment 2

[Jason Smith [:jsmith]]

I wouldn't be surprised if this bug has been present for a long time - the app manager workflow is developer driven, not user driven, so there's likely going to be bugs like this. This isn't critical however - developers can tolerate these bugs far better than users. I definitely don't think this is a blocker.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: -'ing as this is a developer facing issue.

Paul, I suppose app manager will update the installed app, not create duplicate entries. If you could confirm that then this is a Settings app issue. Could you confirm that?

Comment 4

[Paul Rouget [:paul]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> Triage: -'ing as this is a developer facing issue.
> 
> Paul, I suppose app manager will update the installed app, not create
> duplicate entries. If you could confirm that then this is a Settings app
> issue. Could you confirm that?

It updates the app code and reloads the running app (if running). So I guess it's an issue with the setting. But maybe you want to check the install method: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/webapps.js#359

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Paul, thanks for info.

After trying to repro locally and |adb shell /data/local/webapps|, this is what I found:

-- the first two duplicate entries are indeed different apps of the same name (the first one being the one preloaded in the build, taking a gaiamobile.org url instead of an UUID
-- this is indeed an Settings app issue because when I kill the Settings app and re-launch, the third entry (and so on) disappeared.

I guess the Application Permission UI does not account the situation where the app was re-installed. To fix this bug, we should look for existing entries (by comparing the manifest URL) and update it (assuming the name has changed) instead of inserting one w/o checking.

Comment 6

[BMO Automation]

Firefox OS is not being worked on