943831 - Apps can be size incorrectly, ignoring the viewport rules

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I have seen that a few times by opening the Galery app with APZ turned on (i don't have a SD card in this device). The app seems zoomed out, like if the <meta viewport> info has not been taken into account.

One step to reproduce is:
 - Open the sms app
 - Click on the 'New Message' button
 - Click on the 'Add attachment' button
 - In the activity selector, click the galery app

Expected result:
 - The gallery app opens with the right size

Actual result:
 - The gallery app opens like if there is no meta viewport.

Note: There is no SD card in this phone.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Actually it seems like there is a race somewhere. I can reproduce the issue just by opening the gallery app directly from the homescreen. But it does not happens all the time.

So I found a nicer way to reproduce this for all apps:
 - Click on the homescreen to open the application of your choice
 - Very quickly hit home after the previous step
 - wait a little bit
 - Click on the app icon again (Note that sometime you have to hit home again otherwise nothing happens when you click on the homescreen, sounds like a Gaia bug).

Expected result:
 - the application correctly sized

Actual result:
 - The application is wrongly sized, taking only a small part of the screen

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug943831.wip.patch

Seems like a regression from bug 943831. kats do you have any idea it we really need to return early if there is no scroll identifiers ?

So basically if the application is launched and then quickly hidden, we never set the viewport correctly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8341073 [details] [diff] [review]
bug943831.wip.patch

Review of attachment 8341073 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with doing this. I would have expected HandlePossibleViewportChange() to get called again when the app is brought to the foreground which would have made this moot. I guess it doesn't really need to be though.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8341073 [details] [diff] [review]
bug943831.wip.patch

Then let's ask r? since I don't know what else I can do here...

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8341073 [details] [diff] [review]
bug943831.wip.patch

Review of attachment 8341073 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/TabChild.cpp
@@ +533,5 @@
>    uint32_t presShellId;
>    ViewID viewId;
> +  if (APZCCallbackHelper::GetScrollIdentifiers(document->GetDocumentElement(),
> +                                               &presShellId, &viewId)) {
> +   SendUpdateZoomConstraints(presShellId,

Fix indent

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30a98b93ba25

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2013-12-04-14-36-51.png

Another way to reproduce this is:
0. turn on APZ in settings
1. make sure camera and gallery are not launched
2. launch camera
3. select gallery

Not sure if this should be a separate bug?

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I guess the only way to find out is to apply the patch.
I noticed some other strange behaviors with not properly resizing when changing orientations as well.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30a98b93ba25

Comment 11

[u279076]

Does this only apply to Firefox OS platforms?