Closed
Bug 943855
Opened 12 years ago
Closed 11 years ago
Caption for sad feedback button appears off center
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g-v1.4 fixed)
VERIFIED
FIXED
1.4 S4 (28mar)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | fixed |
People
(Reporter: stef, Assigned: flod)
Details
(Keywords: l12y)
Attachments
(2 files)
Comparison current/patched Gaia
This was originally reported in bug 930726 comment 3 and seems to be a styling issue affecting l10n: in polish fierfox os v 1.2 the caption for sad (pl: „Kiepsko”) appears off center.
Screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=8338731
|
Assignee | |
Comment 1•11 years ago
|
||
Still happening on master (1.4). Not just the sad face caption is misaligned, but the layout also breaks badly with long strings.
|
|
Assignee | |
Comment 2•11 years ago
|
||
:evelyn
Not sure if you're the right reviewer for this, feel free to point the review to the right person.
Assignee: nobody → francesco.lodolo
Attachment #8389258 -
Flags: review?(ehung)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8389258 [details] [review]
Pull request on Github
good! thanks for catch this!
Attachment #8389258 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks for the review.
Rebase looks clean, previous Travis run green, setting checkin-needed
https://travis-ci.org/mozilla-b2g/gaia/builds/20680858
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Master: c4f674d0ae46d9b40220894d16f12b9fe7c07c01
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v1.4:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Verified on Keon, master git commit 3977de3c 2014-03-24
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•