Closed Bug 943855 Opened 8 years ago Closed 7 years ago

Caption for sad feedback button appears off center

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

VERIFIED FIXED
1.4 S4 (28mar)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: stef, Assigned: flod)

Details

(Keywords: l12y)

Attachments

(2 files)

This was originally reported in bug 930726 comment 3 and seems to be a styling issue affecting l10n: in polish fierfox os v 1.2 the caption for sad (pl: „Kiepsko”) appears off center.

Screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=8338731
Still happening on master (1.4). Not just the sad face caption is misaligned, but the layout also breaks badly with long strings.
Attached file Pull request on Github
:evelyn
Not sure if you're the right reviewer for this, feel free to point the review to the right person.
Assignee: nobody → francesco.lodolo
Attachment #8389258 - Flags: review?(ehung)
Comment on attachment 8389258 [details] [review]
Pull request on Github

good! thanks for catch this!
Attachment #8389258 - Flags: review?(ehung) → review+
Thanks for the review.

Rebase looks clean, previous Travis run green, setting checkin-needed
https://travis-ci.org/mozilla-b2g/gaia/builds/20680858
Status: NEW → ASSIGNED
Keywords: checkin-needed
Master: c4f674d0ae46d9b40220894d16f12b9fe7c07c01
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
Verified on Keon, master git commit 3977de3c 2014-03-24
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.