943860 - Autophone - detect tree/procname by detecting branch in repo rather than checking for exact matches

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: build-repo.patch

When testing local fennec builds in Autophone I found that the logic in builds.py:build_metadata would not detect the repo properly due to the fact that my local builds did not have the canonical repo url in application.ini's SourceRepository. I think checking for the branch substrings is sufficient rather than the more restrictive check for equality.

Comment 1

[Mark Côté [:mcote]]

Comment on attachment 8339277 [details] [diff] [review]
build-repo.patch

Review of attachment 8339277 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, since I imagine most people won't check out source to a weird directory name.

It's fine as it is, but now it looks more clearly redundant...I might loop over a tuple of tuples of the form (tree, proc_name), e.g. (('mozilla-central', 'org.mozilla.fennec'), ('mozilla-inbound', 'org.mozilla.fennec'), ...) instead of all the if clauses.  Avoids repeating the tree name string and thus reduces possibilities for typos.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: build-repo-2.patch

updated to iterate over tuples

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/cfc19311aed6cd995d4d63f9927b2ac9ae3f1701