Created attachment 8339297 [details] Nightly (11/27) - Screenshot Currently when one conducts a Google Search, the throbber sticks around and the favicon does not appear at all. So far for whatever reason I am only able to reproduce through long-tap, 'Google Search' with selected text. Tap test-case URL, long tap on selected text and open the dotted menu and select 'Google Search'. See screenshot. -- Nightly (11/27) | LG Nexus 4 (Android 4.4)
Also seeing this on tab restoration of Google searches
D/GeckoToolbar( 9024): onTabChanged: STOP D/GeckoToolbar( 9024): setProgressVisibility: false D/GeckoToolbar( 9024): setFavicon(null) D/GeckoToolbar( 9024): Ignoring favicon set: new favicon is identical to previous favicon. I/GeckoToolbar( 9024): zerdatime 3875233 - Throbber stop
I think we are returning early from setFavicon because the incoming image is null and the mLastFavicon is null. We should be setting the favicon to a null drawable.
I can repro using the STR
I believe this is fixed by my partial backout and partial re-land in Bug 941868. The issue was not the de-bouncing; it was that restored tabs (and certain other situations) send an almost-non-overlapping set of messages, and the logic I'd changed to do less work thus caused us to do... no work. Aaron, please verify when that hits Nightly again!
Fixed via 941868.