943897 - Code timeout into contacts_settings.tap_import_from_sim()

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)

Description

[Zac C (:zac)]

The 
self.wait_for_element_not_displayed(*self._loading_overlay_locator)

needs to be overridden to use a larger timeout because if the command line timeout is set to <10seconds then this wait does not wait for long enough.

Please run the test importing 5-10 contacts and judge how much time it will need. Accomodate for slower hardware/speed, don't be afraid to be generous with the timeout.

Comment 1

[Zac C (:zac)]

This could be (number_of_contacts_on_sim * default timeout) for example.

Comment 2

[Florin Strugariu [:Bebe]]

Also please do the same in test_ftu_skip_tour.py

Comment 3

[Robert Chira [:RobertC]]

Attachment: Pull request

Comment 4

[Florin Strugariu [:Bebe]]

Zac is the `self.marionette.timeout` the right timeout to use here?

Comment 5

[Zac C (:zac)]

Yes that's right correct timeout Bebe.

Comment 6

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/afa7142f2dc49b5b131ca48bfe818e2dfda15298

Comment 7

[Zac C (:zac)]

Reverted:
https://github.com/mozilla-b2g/gaia/commit/cc1f1a807d0e3ce0437310a28e71501d720b4b3d

The passed-in time is not converted to seconds.

Comment 9

[Florin Strugariu [:Bebe]]

This revert found a bigger issue in our test framework 
Bug 949543 - Use seconds for defining time in Marionette Python client

Let's fix this bug first and then this one

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

is this bug still active, I am under the impression firefox os is not an active project anymore.

Comment 11

[Martijn Wargers (dead)]

Pretty sure it isn't.