Closed Bug 943914 Opened 12 years ago Closed 12 years ago

[marionette-js-runner] Invalid host IDs are not propagated

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jugglinmike, Assigned: jugglinmike)

Details

Attachments

(1 file)

Pull request on GitHub
59 bytes, text/x-github-pull-request
Details | Review
`ChildRunner#stopHost` or `ChildRunner#restartHost` both throw an error when invoked with an invalid `remoteId`. Instead of being propagated through the asynchronous call chain (where the user can respond in some way), the error goes uncaught.
Assignee: nobody → mike
Attached file Pull request on GitHub —
Hi Gareth, I've also updated these two methods' parameter names to match the documentation.
Attachment #8339336 - Flags: review?(gaye)
Thanks Mike! r=me. https://github.com/mozilla-b2g/marionette-js-runner/commit/999c01c1b655d3c5555bd746310048aa343ec2a4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #8339336 - Flags: review?(gaye)
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: