944024 - Set reviewed date on packaged app updates when approved

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[Rob Hudson [:robhudson]]

Currently it appears as if we are not setting the reviewed date when a packaged app update is approved. For example, on -dev the app loqui has 2 non-deleted versions:

mysql> select addon_id, version, modified, reviewed from versions where addon_id=448292 and deleted=0;
+----------+---------+---------------------+---------------------+
| addon_id | version | modified            | reviewed            |
+----------+---------+---------------------+---------------------+
|   448292 | 009     | 2013-06-21 03:14:41 | 2013-06-23 19:47:09 |
|   448292 | v0.0.11 | 2013-09-08 11:30:07 | NULL                |
+----------+---------+---------------------+---------------------+
2 rows in set (0.00 sec)

The latest version, v0.0.11, was approved 2013-07-29 according to the review logs but the date wasn't set.

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/e118cc3 

Might be difficult to verify unless you have db access, but could always ask someone to check the db for you. Let me know and I'd be happy to.

Comment 2

[Victor Carciu]

(In reply to Rob Hudson [:robhudson] from comment #1)
> https://github.com/mozilla/zamboni/commit/e118cc3 
> 
> Might be difficult to verify unless you have db access, but could always ask
> someone to check the db for you. Let me know and I'd be happy to.

I added and approved a new version for https://marketplace-dev.allizom.org/app/cuowblelpen-io-moundetmak-4/ . 

Can you please let me know if everything was correctly updated in db?

Comment 3

[Rob Hudson [:robhudson]]

Yep, reviewed date was added:

mysql> select id, version, created, reviewed from versions where addon_id=472081;
+---------+---------+---------------------+---------------------+
| id      | version | created             | reviewed            |
+---------+---------+---------------------+---------------------+
| 1496991 | 24.0    | 2013-12-06 08:04:45 | 2013-12-09 07:02:01 |
| 1497153 | 25.0    | 2013-12-09 07:06:04 | 2013-12-09 07:08:19 |
+---------+---------+---------------------+---------------------+
2 rows in set (0.00 sec)

Comment 4

[Victor Carciu]

Thank you Rob!

Verified as fixed.