Closed Bug 944026 Opened 11 years ago Closed 11 years ago

[e.me][bug] Icons are not the correct size

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ranbena, Assigned: evyatar)

References

Details

(Whiteboard: [1.3:P2])

Attachments

(2 files, 1 obsolete file)

Patryk noted that the installed app icons in E.me results are 4px smaller than in their original grid form.
Blocks: 1.3-e.me
Whiteboard: [1.3:P2]
Assignee: nobody → evyatar
Attached file Patch - redirect to github PR (obsolete) —
Attachment #8339999 - Flags: review?(ran)
Attachment #8339999 - Flags: review?(amirn)
Attachment #8339999 - Flags: review?(amirn)
Comment on attachment 8339999 [details] [review]
Patch - redirect to github PR

Good job
Attachment #8339999 - Flags: review?(ran) → review+
landed on master
c0c208fbe11660ad1f026dd8a9c19d9fc5d49a71

https://github.com/mozilla-b2g/gaia/commit/c0c208fbe11660ad1f026dd8a9c19d9fc5d49a71
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attached image Shadow is cut off
Regression from Bug 939738 -
The shadow is cut 1-2px short at the bottom (see attachment).

Thanks.
Flags: needinfo?(evyatar)
Fixed. I also noticed the Cloud Apps shadow is cut, fixed that as well.
What I did is add a bottom-padding to the canvas, according to the shadow size.

https://github.com/mozilla-b2g/gaia/pull/14238
Flags: needinfo?(evyatar) → needinfo?(amirn)
small comments on Github
Flags: needinfo?(amirn)
Reverted my previous commit
4f36cf15cee8b4dfcaa7dc8a91d691032b6bf5dc

https://github.com/mozilla-b2g/gaia/commit/4f36cf15cee8b4dfcaa7dc8a91d691032b6bf5dc
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created a new PR - it fixes the regression noticed by Amir, plus fixes a minor cut-off (about 2 pixels) of the Cloud App icons shadow.

r? from Cristian, since I made a small change to a homescreen file - page.js.
Attachment #8339999 - Attachment is obsolete: true
Attachment #8340954 - Flags: review?(crdlc)
Attachment #8340954 - Flags: review?(amirn)
Comment on attachment 8340954 [details] [review]
New Patch - redirect to github PR

OK, fixed the reference to "this", thanks a lot my friend
Attachment #8340954 - Flags: review?(crdlc) → review+
Attachment #8340954 - Flags: review?(amirn) → review+
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: