944109 - Heroed collection images are 403ing

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

GET https://marketplace-dev-cdn.allizom.org/api/rocketfuel/collections/181/image/?be6497a-529667d6 403 (Forbidden)

I assume this is because of nginx or something. IDK.

Comment 1

[Wil Clouser [:clouserw]]

Is this related to bug 912491?

Comment 3

[Jeremy Orem [:oremj]]

This is blocked by https://github.com/mozilla-services/svcops-puppet/blob/9441d7ecd9465c1ba76e235ca55525dc3e8969fc/modules/marketplace/templates/nginx/marketplace.conf?source=cc#L127

Only urls ending in that group of extensions is allowed by the CDN vserver.

Comment 4

[Wil Clouser [:clouserw]]

Good call, thanks.  We should make this URL end in .png or whatever is appropriate.

Comment 6

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/bd2e346

Comment 7

[Wil Clouser [:clouserw]]

thanks

Comment 8

[Iulian Timis]

Now we are not able to change or save an image for an old/new collection. Please see screencast http://screencast.com/t/qpVdqqvvxtJ
Tried with the following collection https://marketplace-dev.allizom.org/curation/collection/jason-praz

Comment 9

[Mathieu Pillard [:mat]]

The curation tool tries to make a PUT request to /image/, but we changed it to /image.png. Tested with a dummy collection:
https://marketplace-dev.allizom.org/api/v1/rocketfuel/collections/209/image/

It's cool that we return something ending in /image.png for GET since that was a requirement for the CDN, but we should accept PUT to /image or /image/, IMHO.

Comment 10

[Mathieu Pillard [:mat]]

Pull Request with the fix: https://github.com/mozilla/zamboni/pull/1547/

Comment 11

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/997ea025166562655c42bfb5d09486fe1178dcc4

Comment 12

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF29 (Win 7).
Postfix screencast http://screencast.com/t/M9OInlgUT1
Closing bug.