Closed Bug 944160 Opened 8 years ago Closed 4 years ago

Re-evaluate AboutHomeComponent Page handling

Categories

(Firefox for Android Graveyard :: Testing, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mcomella, Unassigned)

References

Details

After bug 940565 and (maybe) bug 862805 are implemented, the way HomePager.Page is handled will differ and may make it easier to make our tests more stable.

There are two TODOs in AboutHomeComponent relating to this:

37:        // TODO: A "PhonePage" and "TabletPage" enum should be set explicitly or decided
38-        // dynamically, likely with the work done in bug 940565. The current solution should only
39-        // be temporary

65:    // TODO: Take specific page as parameter rather than swipe in a direction?
66-    public AboutHomeComponent swipeToPageOnRight() {

Tests relying on this functionality should also be updated.
testAboutHomePageNavigation is a prime candidate for re-writing. See the TODO there:

> 12:    // TODO: Define this test dynamically by creating dynamic representations of the Page
> 13-    // enum for both phone and tablet, then swiping through the pages. This will also
> 14-    // benefit having a HomePager with custom pages.
Depends on: 949181
Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.