944160 - Re-evaluate AboutHomeComponent Page handling

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

After bug 940565 and (maybe) bug 862805 are implemented, the way HomePager.Page is handled will differ and may make it easier to make our tests more stable.

There are two TODOs in AboutHomeComponent relating to this:

37:        // TODO: A "PhonePage" and "TabletPage" enum should be set explicitly or decided
38-        // dynamically, likely with the work done in bug 940565. The current solution should only
39-        // be temporary

65:    // TODO: Take specific page as parameter rather than swipe in a direction?
66-    public AboutHomeComponent swipeToPageOnRight() {

Tests relying on this functionality should also be updated.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

testAboutHomePageNavigation is a prime candidate for re-writing. See the TODO there:

> 12:    // TODO: Define this test dynamically by creating dynamic representations of the Page
> 13-    // enum for both phone and tablet, then swiping through the pages. This will also
> 14-    // benefit having a HomePager with custom pages.

Comment 2

[Geoff Brown [:gbrown]]

Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.