944205 - 64bit OpenGL constants literals need to use proper type suffixes

Status: NEW

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Just spotted this flying over my terminal while building B2G:

/hack/mozilla-central/gfx/gl/SharedSurfaceGL.cpp:378: warning: integer constant is too large for 'long' type

The code is

bool
SharedSurface_GLTexture::WaitSync()
{
    MutexAutoLock lock(mMutex);
    if (!mSync) {
        // We must have used glFinish instead of glFenceSync.
        return true;
    }

    MOZ_ASSERT(mConsGL, "Did you forget to call a deferred `SetConsumerGL()`?");
    mConsGL->MakeCurrent();
    MOZ_ASSERT(mConsGL->IsExtensionSupported(GLContext::ARB_sync));

    mConsGL->fWaitSync(mSync,
                       0,
                       LOCAL_GL_TIMEOUT_IGNORED);  // <-- ### here ###
    mConsGL->fDeleteSync(mSync);
    mSync = 0;

    return true;
}

It looks like this could mean that the timeout value we pass to WaitSync isn't the one we intend to!

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: The glass is also half 0xFFFFFFFFFFFFFFFFull

It's not so bad after all.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8339664 [details] [diff] [review]
The glass is also half 0xFFFFFFFFFFFFFFFFull

Review of attachment 8339664 [details] [diff] [review]:
-----------------------------------------------------------------

Hah.