Closed
Bug 944207
Opened 12 years ago
Closed 12 years ago
Reset the number of HWC layers on failures before HWC prepare.
Categories
(Core Graveyard :: Widget: Gonk, defect, P2)
Tracking
(blocking-b2g:1.3+, firefox28 fixed)
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: sushilchauhan, Assigned: sushilchauhan)
Details
Attachments
(1 file, 1 obsolete file)
|
1.26 KB,
patch
|
sushilchauhan
:
review+
|
Details | Diff | Splinter Review |
Observed that for the first frame after boot, PrepareLayerList() is successful hence number of HWC layers > 0 but it lands in "FBSurface not initialized" failure in TryHwComposition() and fall back to GPU Composition. Subsequently, in Render(), the decision to call Prepare() is based on the number of HWC layers. Hence, hwc set gets called without prepare. So, reset the number of HWC layers on any failure before prepare.
Attachment #8339669 -
Flags: review?(dwilson)
|
||
Updated•12 years ago
|
Assignee: nobody → sushilchauhan
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Updated•12 years ago
|
blocking-b2g: --- → 1.3+
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8339669 [details] [diff] [review]
Reset number of HWC layers on failures before HWC prepare.
Looks good to me
Attachment #8339669 -
Flags: review?(dwilson) → review+
|
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
Uploading HG friendly patch.
Attachment #8339669 -
Attachment is obsolete: true
Attachment #8340518 -
Flags: review+
Keywords: checkin-needed
|
||
Updated•12 years ago
|
Component: General → Widget: Gonk
Product: Firefox OS → Core
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•12 years ago
|
status-firefox28:
--- → fixed
|
|
||
Updated•11 years ago
|
Flags: in-moztrap-
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•