Closed Bug 944207 Opened 6 years ago Closed 6 years ago

Reset the number of HWC layers on failures before HWC prepare.

Categories

(Core Graveyard :: Widget: Gonk, defect, P2)

Product:
Core Graveyard
Component:
Widget: Gonk
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:1.3+, firefox28 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla28
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox28 --- fixed

People

(Reporter: sushilchauhan, Assigned: sushilchauhan)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 944207 - Reset the number of HWC layers on failures before HWC prepare. r=dwilson
1.26 KB, patch
sushilchauhan
: review+
Details | Diff | Splinter Review 
Observed that for the first frame after boot, PrepareLayerList() is successful hence number of HWC layers > 0 but it lands in "FBSurface not initialized" failure in TryHwComposition() and fall back to GPU Composition. Subsequently, in Render(), the decision to call Prepare() is based on the number of HWC layers. Hence, hwc set gets called without prepare. So, reset the number of HWC layers on any failure before prepare.
Attachment #8339669 - Flags: review?(dwilson)
Assignee: nobody → sushilchauhan
Status: UNCONFIRMED → NEW
Ever confirmed: true
blocking-b2g: --- → 1.3+
Comment on attachment 8339669 [details] [diff] [review]
Reset number of HWC layers on failures before HWC prepare.

Looks good to me
Attachment #8339669 - Flags: review?(dwilson) → review+
Status: NEW → ASSIGNED
Will upload HG friendly patch.
Keywords: checkin-needed
Uploading HG friendly patch.
Attachment #8339669 - Attachment is obsolete: true
Attachment #8340518 - Flags: review+
Keywords: checkin-needed
Component: General → Widget: Gonk
Product: Firefox OS → Core
https://hg.mozilla.org/mozilla-central/rev/2c4b329c1a96
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Flags: in-moztrap-
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.