Closed Bug 944229 Opened 6 years ago Closed 6 years ago

[OS X] There is no space above the tabs in fullscreen with private browsing

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: MattN, Assigned: nmaier)

References

(Depends on 1 open bug)

Details

(Keywords: ux-consistency, Whiteboard: [Australis:P3])

Attachments

(2 files)

Attached image noLWT_fullScreen.png
There should be a consistent space above the tabstrip regardless of PB, LWT, or sizemode. The space is currently lacking in PB mode when in fullscreen.

If bug 944228 is fixed, the test added there should be updated.
This is basically the same (well, a little different) as the bits from my patch in bug 939010 comment 9, except that it does introduce the same wrong padding normal and lwt windows have. That wrong padding is bug 878436.
Attachment #8339746 - Flags: review?(MattN+bmo)
Blocks: 878436
Sorry for the delay, I'll get to this review tomorrow.
Assignee: nobody → maierman
Status: NEW → ASSIGNED
Comment on attachment 8339746 [details] [diff] [review]
Add padding to PB windows in OSX native fullscreen mode

Review of attachment 8339746 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

::: browser/themes/osx/browser.css
@@ +3597,5 @@
>      padding-top: 11px;
> +  }
> +  #main-window[inFullscreen]:not([privatebrowsingmode=temporary]):-moz-lwtheme {
> +    /* In combination with the previous rule, forces the top 22px of the
> +     * background image to be hidden, so there image doesn't jump around with

Nit from existing comment: s/there image/the image/
Attachment #8339746 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/integration/fx-team/rev/51c1585b15be
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/51c1585b15be
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.