944240 - Avoid quoting issues with GNU make on windows

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Mike Hommey [:glandium]]

Pristine GNU make has heuristics as to when to use a shell for recipe commands, and when not to. When it does, it runs a command like sh -c "the command". Unfortunately, msys bash handles double quotes badly in that case (although make does the right escaping) and that make the commands not get the right arguments.

In NSS's case, this happens with lib -out:"foo.lib" commands.

We work around this by using mozmake, which enables a GNU make feature that makes shell invocations always create a shell script in invoke it instead of using sh -c. But on the long run, I'd like us to be able to use a pristine (non-msys) GNU make.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove quotes around target file name for NSS library linking

The rationale here is that $@ is never going to have characters that require quoting in it, since it's a library name.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

I will check this into NSS and then update NSS in mozilla-central.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

http://hg.mozilla.org/projects/nss/rev/ead5dfef5276

There will be a checkin to mozilla-inbound in bug 898431.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Pushed to inbound in bug 898431:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e9d5098d95f