944259 - compiler warning in nsCSSRenderingBorders.cpp under OSX

Status: RESOLVED DUPLICATE of bug 829993

(Core :: CSS Parsing and Computation, defect)

Description

[John Daggett (:jtd)]

In file included from /builds/mozcentral/obj-debug/layout/base/Unified_cpp_layout_base1.cpp:11:
Warning: -Wsometimes-uninitialized in /builds/mozcentral/layout/base/nsCSSRenderingBorders.cpp: variable 'borderRenderStyle' is used uninitialized whenever 'for' loop exits because its condition is false
/builds/mozcentral/layout/base/nsCSSRenderingBorders.cpp:739:21: warning: variable 'borderRenderStyle' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized]
  NS_FOR_CSS_SIDES (i) {
                    ^~
/builds/mozcentral/layout/base/../style/nsStyleConsts.h:22:76: note: expanded from macro 'NS_FOR_CSS_SIDES'
#define NS_FOR_CSS_SIDES(var_) for (mozilla::css::Side var_ = NS_SIDE_TOP; var_ <= NS_SIDE_LEFT; var_++)
                                                                           ^
/builds/mozcentral/layout/base/nsCSSRenderingBorders.cpp:748:7: note: uninitialized use occurs here
  if (borderRenderStyle == NS_STYLE_BORDER_STYLE_NONE ||
      ^~~~~~~~~~~~~~~~~

Comment 1

[John Daggett (:jtd)]

Attachment: patch, initialize borderRenderStyle to NS_STYLE_BORDER_STYLE_NONE

Comment 2

[Cameron McCormack (:heycam)]

Dupe of bug 829993, where dbaron has r-ed an identical patch.  (I would prefer we did something to silence the warning, though, so please try to convince David!)

Comment 3

[John Daggett (:jtd)]

argh, checkin comment used this bug number.  please resolve bug 829993.  sorry for the bother.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b395bc2b9ba9