Closed Bug 944279 Opened 8 years ago Closed 8 years ago

marionette_js reporter should be more verbose

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rik, Assigned: rik)

References

Details

Attachments

(1 file, 2 obsolete files)

Lots of marionette_js builds are erroring (gray). And we have no insight why because the reporter is only outputting dots for every test. It would be great to output the test name so that we can see which tests are timeouting the most and take it from there.



npm WARN package.json marionette-client@1.1.0 No repository field.
npm WARN package.json marionette-content-script@0.0.0 No repository field.
npm WARN package.json marionette-device-host@0.0.1 No repository field.
npm WARN package.json marionette-js-runner@0.4.0 No repository field.
npm WARN package.json marionette-profile-builder@0.0.2 No repository field.

․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
․․․․․․․․․․․

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated
Hi Anthony,

I think this https://travis-ci.org/mozilla-b2g/gaia/jobs/14682479 is what we want.
Attached file Pull request (obsolete) —
Attachment #8340193 - Flags: review?(anthony)
Attachment #8340193 - Attachment mime type: text/plain → text/html
Comment on attachment 8340193 [details]
Pull request

Thanks for the patch, I was lazy not to investigate.

I'd rather get rid of the MOCHA_REPORTER var because we already have the REPORTER one that serves the same purpose.
Attachment #8340193 - Flags: review?(anthony) → review-
Assignee: nobody → anthony
Attachment #8340193 - Attachment is obsolete: true
Attachment #8340206 - Flags: review?(felash)
Comment on attachment 8340193 [details]
Pull request

Yes, I update the patch for the REPORTER.
Attachment #8340193 - Flags: review- → review?(anthony)
Comment on attachment 8340206 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14199

Both patches are essentially the same but this one removes the obsolete MOCHA_REPORTER var. So r=me for this.

That said, I'm not a build peer. Yuren, could you please have a final look on this?
Attachment #8340206 - Flags: review?(felash) → review?(yurenju.mozilla)
Comment on attachment 8340193 [details]
Pull request

Removing the r? request on this one.
Attachment #8340193 - Flags: review?(anthony)
Attachment #8340206 - Flags: review?(yurenju.mozilla) → review+
I had to back this out because it fails on Travis :(
https://github.com/mozilla-b2g/gaia/commit/ecc38f971f6b892bea2903361a719e68ec33aac6

Error: Cannot find module 'mocha/lib/reporters/Spec'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at getOpts (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-js-runner/bin/marionette-mocha:26:16)
at main (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-js-runner/bin/marionette-mocha:145:14)
at Object.<anonymous> (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-js-runner/bin/marionette-mocha:151:3)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
make: *** [test-integration] Error 8
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The issue was the capitalised 'Spec'. Re-landed with https://github.com/mozilla-b2g/gaia/commit/6f4b4069b6153c6c719559b690bd3e0654676bbe
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
And now I've broken |APP=communications/dialer make test-agent-test| locally… So preparing another pull request.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'll be travelling for the next 20 hours so feel free to merge this if it's r+ and doesn't break travis.
Attachment #8340206 - Attachment is obsolete: true
Attachment #8340298 - Flags: review?(yurenju.mozilla)
https://github.com/mozilla-b2g/gaia/commit/e08d329a9b0091a8b9d6ab531198f81ad411f141 broke the Travis integration. So I went ahead and merged attachment 8340298 [details] [review] in https://github.com/mozilla-b2g/gaia/commit/f64d282b6b44eaaf8cddc8be8f3250cb6fbacd95.
Yuren: Please, can you still review my change? I just merged it ahead so that our continuous integration still runs.

Rick: Since you commented on the commit in Github, you could have looked at the referenced bug and see the pull request. Also, it's not ok to do a commit without a reviewer, nor a bug referenced. And if you do so, it would actually be nice to watch Travis after doing so. Still I want to thank you for caring and trying to unbreak running the tests locally.
Comment on attachment 8340298 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14213

The main problem is we use two different strings between test-agent and gaia-marionette, e.g., "Spec" and "spec"

mocha require all reporter with capitalization module names, so we should make gaia-marionette support capitalization reporter name such as "Spec" and "Dot".

however we already landed this commit, so let's file another one to fix this issue.
Attachment #8340298 - Flags: review?(yurenju.mozilla) → review+
Thanks Yuren! Closing since the goal of this bug is achieved. The cleaner long term fix will be in bug 945095.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.