944284 - [UITest] add dial number activity

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

Expect:

extend test_apps/uitest by add dial number activity in API tab


The activity could reference to http://robnyman.github.io/Firefox-OS-Boilerplate-App

var dial = document.querySelector("#dial");
    if (dial) {
        dial.onclick = function () {
            var call = new MozActivity({
                name: "dial",
                data: {
                    number: "[phone]"
                }
            });
        }
    }

Comment 1

[kumar rishav (:rishav_)]

Hi Fred,
Can I get assigned this bug? I am interested in this. :)
Thanks

Comment 2

[[e-mail]]

Hi kumar, please choose one by one before you take other bug.
You are free to do it in parallel though, since there's no other express the interest.

Comment 3

[kumar rishav (:rishav_)]

Hi Fred,
Actually all these bugs belong to same category , so i thought to do all together.
Sorry for that..
I will do one by one..
Thanks

Comment 4

[kumar rishav (:rishav_)]

Attachment: Add Dail Number Activity

Hi fred,
Have a look on this patch, is it allright?
Thanks

Comment 5

[[e-mail]]

Comment on attachment 8351215 [details] [review]
Add Dail Number Activity

Thanks for contribution!

Please check github for styling issues.

Set review again once you've done.

Comment 6

[kumar rishav (:rishav_)]

Attachment: Add Dail Number Activity and align in same line

Hi fred..
I corrected the spell mistake (dail--> dial) and using linter i corrected styling in .js file. but aligning in index.html is not happening. It is fine in my editor(i tried 2-3 times), but when i pushed it to remote branch, it again de-align. should i edit the code from git hub instead of my text editor.
Thanks

Comment 7

[[e-mail]]

please set your editor with `soft tab: 2` (use 2 space instead of 1 tab). Or just change lines with space.
I recommend `sublime editor` but it just one of the option.

edit on github directly will create new commit, you still need squash them into 1 commit

Comment 8

[kumar rishav (:rishav_)]

Attachment: Add Dail Number Activity and align in same line

Hi Fred,
I think Everything is all right now.
Please have a look, if every thing is right then please assign other bug i requested.
Thanks

Comment 9

[[e-mail]]

Thanks! I'll review it soon.
You can take any bug before assigned, just leave a message to tell others you are working on it now.

Comment 10

[[e-mail]]

Comment on attachment 8351301 [details] [review]
Add Dail Number Activity and align in same line

please fix style issue then set review again, thanks!

Comment 11

[[e-mail]]

It will better to put the number you want to dial on screen,
or have a input area to enter other number for test. (should have a default number)

Comment 12

[kumar rishav (:rishav_)]

Hi fred.
Instead of that can i put that place empty, so that user can enter the number, he wants?
Something like this(i attached few images).
Please check this.
Are you online now??
Thanks

Comment 13

[kumar rishav (:rishav_)]

Attachment: im1.png

Comment 14

[kumar rishav (:rishav_)]

Attachment: im2.png

Comment 15

[kumar rishav (:rishav_)]

Attachment: im3.png

Comment 16

[[e-mail]]

No, the uitest app is also used by auto test, so a default number is better than a blank one.
I can accept current PR.

Sorry I'm during Christmas vacation so the feedback might be late.

Comment 17

[[e-mail]]

Comment on attachment 8351301 [details] [review]
Add Dail Number Activity and align in same line

merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/8f6489ebbb2f869534abd3232095128ce51460a8

thanks