Closed Bug 944286 Opened 11 years ago Closed 11 years ago

[UITest] add send SMS activity

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: rishav_)

Details

(Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh][lang=js])

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review
Expect:

extend test_apps/uitest by add send SMS activity in API tab


The activity could reference to http://robnyman.github.io/Firefox-OS-Boilerplate-App

var sendSMS = document.querySelector("#send-sms");
    if (sendSMS) {
        sendSMS.onclick = function () {
            var sms = new MozActivity({
                name: "new", // Possible compose-sms in future versions
                data: {
                    type: "websms/sms",
                    number: "+46777888999"
                }
            });
        }
    }
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh][lang=js]
Hi Fred,
Can I get assigned this bug? I am interested in this. :)
Thanks
Hi Fred, 
I am working on this bug.Please assign this to me.
Thanks.
Assignee: nobody → rishav006
Hi Fred
Please have a look on this patch.
I am unable to add this link as a patch (i don't know why this is happening).

https://github.com/mozilla-b2g/gaia/pull/14959

Thanks
Attached file Add send SMS activity (obsolete) —
Now it's working fine.
Attachment #8351435 - Flags: review?(gasolin)
Attached file Add send SMS activity
Attachment #8351435 - Attachment is obsolete: true
Attachment #8351435 - Flags: review?(gasolin)
Attachment #8351437 - Flags: review?(gasolin)
Comment on attachment 8351437 [details] [review]
Add send SMS activity

The code looks good, thanks for contribution!


@steve, I can't show phone number on SMS message editor page correctly in gaia-master, in 1.3, it works fine.

Is it a known bug?
Attachment #8351437 - Flags: review?(gasolin) → review+
Flags: needinfo?(schung)
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/7545846ed56a08bdcb8a5a9e6380f23b930ce1f9

thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Not sure the root cause for this issue, but I just tried the same behavior to open the message app with specific number by dailer and contacts and both works fine. But we just landed a huge patch about message draft mode, which might be possible to chage the original logic. I will investigate this issue later, thanks for remider!
Flags: needinfo?(schung)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: