944287 - [UITest] add share URL activity

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

Expect:

extend test_apps/uitest by add 'share URL' activity in API tab


The activity could reference to http://robnyman.github.io/Firefox-OS-Boilerplate-App

var share = document.querySelector("#share");
    if (share) {
        share.onclick = function () {
            var sharing = new MozActivity({
                name: "share",
                data: {
                    //type: "url", // Possibly text/html in future versions,
                    number: 1,
                    url: "http://robertnyman.com"
                }
            });
        }
    }

Comment 1

[kumar rishav (:rishav_)]

Hi Fred,
Can I get assigned this bug? I am interested in this. :)
Thanks

Comment 2

[kumar rishav (:rishav_)]

Attachment: Add share URL Activity

Hi Fred,
I am working on this bug.
Please assign this to me.
Please have a look on this attached PR.
Thanks

Comment 3

[[e-mail]]

Hi kumar,

Thanks for provide a PR. I'm in holiday off and try to do some other project, so the review might be late.
You can still work on bugs.

Happy coding holidays!

Comment 4

[[e-mail]]

please check github

Comment 5

[kumar rishav (:rishav_)]

Hi fred,
I changed the url.
Now,please have a look.
Thanks

Comment 6

[[e-mail]]

Comment on attachment 8351473 [details] [review]
Add share URL Activity

looks good to me, please squash your commits into 1 commit. It's needed to maintain the commits clean.

You could use command

$ git rebase -i HEAD~2

to merge 2 commits into 1 commit.

Then push back to the same branch via command

$ git push --force origin issue-xxxx



or you could just create new branch.

Comment 7

[kumar rishav (:rishav_)]

Attachment: Add share URL Activity

Hi fred,
Have a look on this PR.
I think now every thing is right.
Thanks

Comment 8

[[e-mail]]

Comment on attachment 8355129 [details] [review]
Add share URL Activity

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/9f7eeeb0bb5fd4b73eab60c826c74dffdc341f3f

thanks!