944347 - Disable fluffling for 1.2

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Fluffling has a few issues that have popped up late in the process. Let's disable it for 1.2 and keep fixing it for 1.3.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug944347.patch

Comment 2

[Jason Smith [:jsmith]]

Blocking+ - this is turning off a non-ready feature for 1.2.

Comment 3

[Gregor Wagner [:gwagner]]

Can we enable it in the browser?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> Can we enable it in the browser?

If we fix https://bugzilla.mozilla.org/show_bug.cgi?id=942246 and https://bugzilla.mozilla.org/show_bug.cgi?id=941712 we can enable it everywhere :)

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Vivien, I assume you can land this once Fabrice OK's it.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Milan Sreckovic [:milan] from comment #5)
> Vivien, I assume you can land this once Fabrice OK's it.

Yep, just waiting for him to come back from unjustified vacations :)

Comment 7

[Gregor Wagner [:gwagner]]

Comment on attachment 8339885 [details] [diff] [review]
bug944347.patch

Review of attachment 8339885 [details] [diff] [review]:
-----------------------------------------------------------------

Lets land it.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Just realized that I don't have any 1.2 branch on my laptop. Let's do a checking needed.

This stuff should not land on master but only on the branch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b5511620d028

Can you please make sure your future patches have commit information included? Thanks :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b5511620d028
> 
> Can you please make sure your future patches have commit information
> included? Thanks :)
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

My bad. I own you a beer or any drink of your choice.