Closed Bug 944365 Opened 8 years ago Closed 7 years ago

osx compose window should use messageQuotes.css

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 30.0

People

(Reporter: mkmelin, Assigned: Paenglab)

Details

Attachments

(1 file, 3 obsolete files)

Stubmled on this
http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#2239

2238           // See Bug 517919 for discussion of why this exception is thrown
2239           // (at time of writing, on osx, there is no messageQuotes.css)
2240           dump("addOverrideStyleSheet in MsgComposeCommands.js threw an exception, hopefully due to a missing stylesheet\n");

We should fix that - currently osx has the styles in http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/messageBody.css#147. 
I guess this means on mac you don't get different color quotes in the compose window?

Once fixed the try-catch can go to I think.
Attached patch patch (obsolete) — Splinter Review
The patch adds messageQuotes.css to OSX with the styles which are removed from messengercompose.css and messageBody.css.

In MsgComposeCommands.js I removed the try-catch.

This patch changes no style, is a ui-r needed?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8340674 - Flags: review?(mconley)
Attached patch patch unbitrotted (obsolete) — Splinter Review
Updated patch after landing of bug 953011.
Attachment #8340674 - Attachment is obsolete: true
Attachment #8340674 - Flags: review?(mconley)
Attachment #8355294 - Flags: review?(mconley)
Attached patch patch again unbitrotted (obsolete) — Splinter Review
Attachment #8355294 - Attachment is obsolete: true
Attachment #8355294 - Flags: review?(mconley)
Attachment #8358992 - Flags: review?(mconley)
Comment on attachment 8358992 [details] [diff] [review]
patch again unbitrotted

Review of attachment 8358992 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the wait - yeah, let's roll with this. Just one style nit to fix before landing.

::: mail/themes/osx/mail/messageQuotes.css
@@ +24,5 @@
> +
> +/* Quote Levels Colors */
> +
> +blockquote[type=cite] {
> +   color: blue !important;

Nit - two space indentation for these.
Attachment #8358992 - Flags: review?(mconley) → review+
Fixed comment.
Attachment #8358992 - Attachment is obsolete: true
Attachment #8375343 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4e7ae19f3455
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in before you can comment on or make changes to this bug.