[Cost Control] Use "Wi-Fi" consistently in strings instead of wifi

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: flod, Assigned: flod)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://github.com/mozilla-b2g/gaia/pull/13894/files

+reset-wifi = Reset wifi usage
+reset-all-data-usage = Reset mobile & wifi data

"Wi-Fi", not "wifi" (see bug 880710 or bug 814876 for similar issues). No need to change ID, it's just fixing consistency in en-US.
(no access on Github, I'll need someone to merge this when reviewed)
Attachment #8339912 - Flags: review?(salva)
Comment on attachment 8339912 [details] [review]
Update strings with "Wi-Fi"

I don't know if these strings have been yet translated. If not, we can change only the string substitution. But if they have been already translated the we need to pump the key. Asking the l18n community.
Attachment #8339912 - Flags: feedback?(community)
Comment on attachment 8339912 [details] [review]
Update strings with "Wi-Fi"

I'm part of the l10n team and also a localizer (Italian) ;-)

In general, asking an alias for feedback, review or needinfo is not good (no chance to reply).

About the change, see also bug 814876 comment 2. This is fixing consistency in English, each localizer should be responsible to choose its own spelling and be consistent when localizing.
Attachment #8339912 - Flags: feedback?(community)
Comment on attachment 8339912 [details] [review]
Update strings with "Wi-Fi"

I was asking because I know when i18n have provided a translation, in order to warn the translator about a new string, the key have to be pumped. But if you are sure this is not needed, then ping me again and I will merge this.
Attachment #8339912 - Flags: review?(salva) → review+
(In reply to Salvador de la Puente González [:salva] from comment #4)
> I was asking because I know when i18n have provided a translation, in order
> to warn the translator about a new string, the key have to be pumped. But if
> you are sure this is not needed, then ping me again and I will merge this.

Yep, I'm sure. As I said, at least English is free to fix grammar errors without using new IDs.
Keywords: checkin-needed
Master: 880ba425e7dd602dbc9f96faf85df4c4b161db4c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.