944389 - BAD_PRICE_POINT error

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[sailajan.sabaratnam]

Attachment: BAD_PRICE_POINT

Region code: Crow/Germany
Device: Unagi white
Connection: 3G
Phone number/MSISDN: 01756938887
Carrier: Telekom
Last 4 digits CC: n/a
Test App used: HTML Basics

steps to reproduce:

1. Start MP Prod.
2. Search for a paid app such as HTML basics. 
3. Select the price button to start the payment process. 
4. Enter a new username and press ok. 
5. Enter and confirm password and press ok.


expected behavior:

The user is asked to enter and confirm their pin. 

observed behavior:

The user receives an error message "There was en error setting up the payment. try again or contact the app if it persists BAD_PRICE_POINT".

Comment 1

[sailajan.sabaratnam]

Attachment: BAD_PRICE_POINT.png

Comment 2

[sailajan.sabaratnam]

Note that if i dismiss the error message and try again then i am able to enter and confirm the pin and buy the app successfully.

Comment 3

[Andy McKay]

This was a connection error to the marketplace.

Nov 28 14:12:41 localhost: [80.187.103.19] w.pay:ERROR calling get price_price() :/data/mkt.prod/www/marketplace.firefox.com-webpay/deploy-webpay-prod-20131126230518-1af0c4d8bc/webpay/webpay/pay/views.py:97#012Traceback (most recent call last):#012  File "/data/mkt.prod/www/marketplace.firefox.com-webpay/deploy-webpay-prod-20131126230518-1af0c4d8bc/webpay/webpay/pay/views.py", line 95, in process_pay_req#012    marketplace.get_price(pay_req['request']['pricePoint'])#012  File "/data/mkt.prod/www/marketplace.firefox.com-webpay/deploy-webpay-prod-20131126230518-1af0c4d8bc/webpay/lib/marketplace/api.py", line 18, in get_price#012    .get_object(provider='bango', pricePoint=point))#012  File "/data/mkt.prod/www/marketplace.firefox.com-webpay/current/venv/lib/python2.6/site-packages/curling/lib.py", line 195, in get_object#012    res = self.get(**kw)#012  File "/data/mkt.prod/www/marketplace.firefox.com-webpay/current/venv/lib/python2.6/site-packages/curling/lib.py", line 148, in get#012    headers=headers, params=kwargs)#012  File "/data/mkt.prod/www/marketplace.firefox.com-webpay/current/venv/lib/python2.6/site-packages/curling/lib.py", line 258, in _request#012    raise exceptions.HttpServerError('Connection Error')#012HttpServerError: Connection Error#012Content: 

Not sure why that would fail. We could try and make this more robust, but having a working marketplace is essential to webpay in other parts.

Comment 4

[Andy McKay]

* Let's cache the heck out of that get price call and
* If an error occurs, raise an internal webpay error, not a bad price point error.

Comment 5

[Andy McKay]

https://github.com/mozilla/webpay/pull/381

Comment 6

[Victor Carciu]

Verified as fixed