Closed Bug 944413 Opened 11 years ago Closed 11 years ago

[Browser Settings] Fix layout and alignment

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(2 files)

Broswer-settings.png
23.13 KB, image/png
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
benfrancis
: review+
epang
: feedback+
Details | Review
Attached image Broswer-settings.png — 
Low priority compared to refresh items, but when you have time can you help fix this layout issues?  I've attached an image with how it should look.

1.5 rem margins for buttons
3 rem margin for strings

Thanks!
Attached file patch for Gaia/master — 

        Attachment #8339993 -
        Flags: feedback?(epang)

    
    

    
  
Comment on attachment 8339993 [details] [review]
patch for Gaia/master

this looks good, thanks for fixing it so quickly!

        Attachment #8339993 -
        Flags: feedback?(epang) → feedback+

        Attachment #8339993 -
        Flags: review?(bfrancis)

        Attachment #8339993 -
        Flags: review?(bfrancis) → review+

    
    

    
  
Thanks Ben :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/47d2231b8c1e8e1554e7e9dcda5872c0494590de
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: