Closed Bug 944427 Opened 10 years ago Closed 10 years ago

Fix char16_t/wchar_t mismatch in dom/

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox28 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch.diff
14.37 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Attached patch patch.diff — — Splinter Review 
This is a followup of 928351 to fix remaining problems in dom/.

- Explicit casts to jschar are no longer needed (they were not needed for a while, now they cause problems on mingw)
- Use wchar_t instead of PRUnichar (aka. char16_t) in strings used only for Windows API
- Use new char16ptr_t in ShouldProtectPluginCurrentDirectory so that we don't need to worry about char16_t/wchar_t differences.
Attachment #8339997 - Flags: review?(benjamin)
CCing Jim and Brian to inform them about this kind of change.
Attachment #8339997 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/fc2b0e721cd1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28: --- → fixed
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.