Closed
Bug 944427
Opened 11 years ago
Closed 11 years ago
Fix char16_t/wchar_t mismatch in dom/
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
14.37 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This is a followup of 928351 to fix remaining problems in dom/.
- Explicit casts to jschar are no longer needed (they were not needed for a while, now they cause problems on mingw)
- Use wchar_t instead of PRUnichar (aka. char16_t) in strings used only for Windows API
- Use new char16ptr_t in ShouldProtectPluginCurrentDirectory so that we don't need to worry about char16_t/wchar_t differences.
Attachment #8339997 -
Flags: review?(benjamin)
|
||
Comment 1•11 years ago
|
||
CCing Jim and Brian to inform them about this kind of change.
|
||
Updated•11 years ago
|
Attachment #8339997 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Thanks for review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2b0e721cd1
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28:
--- → fixed
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•