Bounding box selection no longer offsets for scroll left

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Near the end of bounding box selections review, I made a change that moved the left detection out of the scroll element, and into its container, which no longer by default accounts for scroll left.

STRs on staging:

1. move the super scrollbar so the right handle is to the far right, and the left handle is in the middle.
2. try to select via bounding box.

Expected: you should see the bounding box.
Actual: you do not because it's to the left, which likely puts it under the scrollable container.
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
Attachment #8340039 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 2

5 years ago
https://github.com/mozilla/popcorn.webmaker.org/commit/fc54323cd2e672f026c6e93617738bb33947ee68

Needs verification.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.