944468 - Flow from Messages app/message thread to Dialer is broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Zac C (:zac)]

STR:
1. Send an SMS to the phone
2. Open messages app/wait for SMS
3. Open message thread
4. Tap header (where phone number is)
5. Select 'call' from activities menu
6. Dialer menu will open
7. Wait two seconds and the Messages app will slide back in.

Device:   Hamachi
Gaia:     0d57ec2801ae125ec855a19cf956ab118660d694
Gecko:    http://hg.mozilla.org/mozilla-central/rev/a5e7f611546f
BuildID   20131128040201
Version   28.0a1
ro.build.version.incremental=eng.archermind.20131114.105818


The regression range is within the last 24hrs of nightly build (27th Nov was a passing build in the Hamachi ui test automation).

Comment 1

[Jason Smith [:jsmith]]

More likely a web activities regression, rather than a SMS app regression.

Comment 2

[Julien Wajsberg [:julienw]]

Or a Dialer regression? (because of step 6, it seems the dialer actually starts up).

Etienne, can you think of any obvious culprit?

Comment 3

[Etienne Segonzac (:etienne)]

Apparently an activity with no return value should *not* call postResult().
It's funny because the code in the dialer hasn't moved since more than a year :)

But anyway the dialer is clearly at fault here, taking.

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR

pretty easy :)

Comment 5

[Julien Wajsberg [:julienw]]

Hey Alive,

The "dial" activity does not have a configured returnValue in the manifest. Therefore, is it expected that calling 'postResult' does anything (here: moving back to the SMS app)? Could we have another bug hiding in the activity management?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

http://mxr.mozilla.org/mozilla-central/source/dom/activities/src/ActivitiesService.jsm#246
It looks like onsuccess is triggered once callee is selected.

I think this is a bug in web activity -- postResult shouldn't trigger activitydone, which makes event handler inside appWindow to open the caller. Maybe file a followup.

BTW https://bugzilla.mozilla.org/show_bug.cgi?id=944253 and one day ago there was a stupid fail.
Francisco had a patch to fix this yesterday and that's why this occurs today. Thanks integration test(any?) and Zac.

Comment 7

[Julien Wajsberg [:julienw]]

yeah I was gonna say bug 944253 revealed this issue.

Will file a bug to ignore postResult if there is not returnValue in the manifest, and we'll see there if it's valid or not.

Comment 8

[Julien Wajsberg [:julienw]]

Filed bug 945130 for the more general issue.

Comment 9

[Jason Smith [:jsmith]]

Etienne - Can you land this? One of our automated tests is disabled due to this bug, so I'd like to get it preffed back on as soon as possible.

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/8527840366eec3252d04e0dad64e7a40dbe3dc56