944485 - TEST-UNEXPECTED-FAIL | browser_UITour.js | Menu should be shown after showMenu() - Got false, strictly expected true

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

First showed up here:

https://tbpl.mozilla.org/?tree=Holly&rev=239122f4ad68

Seems to affect Windows XP and Linux (which both show the menubar by default). I'm heavily leaning towards bug 940902 as the culprit.

10:59:17  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Menu should be shown after showMenu() - Got false, strictly expected true
10:59:17     INFO -  Stack trace:
10:59:17     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_ise :: line 713
10:59:17     INFO -      JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test_menu :: line 243
10:59:17     INFO -      JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test/nextTest/< :: line 96
10:59:17     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Matthew N. [:MattN]]

For a quick fix, this can be backed out of Holly since it doesn't need to be in pre-Australis builds. Otherwise, I can look into why opening the menu is not sync. on these platforms and possibly change the test to wait for the menu to open.

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

(In reply to Matthew N. [:MattN] from comment #1)
> For a quick fix, this can be backed out of Holly since it doesn't need to be
> in pre-Australis builds. Otherwise, I can look into why opening the menu is
> not sync. on these platforms and possibly change the test to wait for the
> menu to open.

If it doesn't need to be there, I guess I'll opt for backing it out. Probably not worth your time to investigate something that doesn't really matter.

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Backed out bug 940902 as https://hg.mozilla.org/projects/holly/rev/f296b665cdb5.