Closed Bug 944493 Opened 6 years ago Closed 6 years ago

Rename PEPseudoSelTrailing in /layout/css.propertie to reflect new string

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: flod, Assigned: heycam)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/3315c6b05d23

This landed as part of bug 922669, introducing a new string (PEPseudoClassNotUserAction), but also changing an existing one without using a new ID.

    1.12 -PEPseudoSelTrailing=Found trailing token after pseudo-element, which must be the last part of a selector:  '%1$S'.
    1.13 +PEPseudoSelTrailing=Expected end of selector or a user action pseudo-class after pseudo-element but found '%1$S'.

Unless there are technical limitations that prevent from using a different ID, this string needs a new one.
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Attached patch stringSplinter Review
I make string changes infrequently enough that I forgot this rule.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8340153 - Flags: review?(francesco.lodolo)
Comment on attachment 8340153 [details] [diff] [review]
string

Review of attachment 8340153 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks.
Attachment #8340153 - Flags: review?(francesco.lodolo) → review+
https://hg.mozilla.org/mozilla-central/rev/196c1863a6ec
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
No longer depends on: 946710
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.