944536 - [Settings] [Followup] 1.3 Visual Refresh of Settings icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Settings_Sprite.zip

Hi Pavel,

This is a follow up bug for 932833 - Visual refresh of settings icons. There's been an edit to Device Info and Help icons. Please replace the sprites with the ones attached here. 

Thanks

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[Eric Pang [:epang] UX]

Comment on attachment 8340161 [details] [review]
patch for Gaia/master

Looks good, but I think we might need a peer review here :)

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8340161 [details] [review]
patch for Gaia/master

disregard comment 2 - this comment was meant for a different bug.

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8340161 [details] [review]
patch for Gaia/master

Hey Amy, can you give review this?  Pavel if Amy says this is good please flag me for review again, thanks!

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 8340161 [details] [review]
patch for Gaia/master

Thanks Pavel!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/09d1f63762aaf645b5b6642d218b40f069b77562

Comment 7

[Amy Lee [:amylee] UX]

(In reply to Eric Pang [:epang] from comment #4)
> Comment on attachment 8340161 [details] [review]
> patch for Gaia/master
> 
> Hey Amy, can you give review this?  Pavel if Amy says this is good please
> flag me for review again, thanks!

Hi Eric, 

Just checked the patch. Looks good to me thanks!