Create after_comment_commit_button hook in upstream

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
Bugzilla-General
--
enhancement
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Andre Klapper, Assigned: dkl)

Tracking

4.5.1
Bugzilla 5.0
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Upstream trunk does not contain the hook after_comment_commit_button which is used by bmo downstream's Needinfo extension (so now I finally found out why it's not showing up as expected in my testing instance). 

Is there a reason to not introduce this hook in upstream, to also keep bmo's diff to upstream two lines smaller?
(Reporter)

Comment 1

4 years ago
Created attachment 8378281 [details] [diff] [review]
v1

Backporting one line of http://bzr.mozilla.org/bmo/4.2/revision/8388 so the next Bugzilla admin who wants to try the Needinfo extension does not need to check if every used hook also actually exists in the upstream core codebase...
Attachment #8378281 - Flags: review?(dkl)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8378281 [details] [diff] [review]
v1

Review of attachment 8378281 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8378281 - Flags: review?(dkl) → review+
(Assignee)

Updated

4 years ago
Flags: approval?
Target Milestone: --- → Bugzilla 5.0
Flags: approval? → approval+
(Assignee)

Comment 3

4 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified template/en/default/bug/edit.html.tmpl
Committed revision 8924.
Assignee: general → dkl
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.