Closed Bug 944572 Opened 6 years ago Closed 6 years ago

[DSDS] Even if SIM card is in slot 1 which is SIM2, import and export function of Contacts app will still show SIM1 in the list.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86_64
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

VERIFIED FIXED
1.3 C1/1.4 S1(20dec)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: echu, Assigned: arcturus)

References

Details

(Whiteboard: [dsds_US_test])

Attachments

(3 files)

No matter insert only one SIM in slot 0 or slot 1, system only shows SIM 1 in import and export page of Contacts app.

* Build Number                
Gaia:     53bd0adc20e83ccf718c6d2c2a3905efb14d1bef
Gecko:    f239e6a56a72096ac4aff3d4cd8fcc01ac9471b5
BuildID   20131129093923
Version   28.0a1

* Reproduce Steps
1. Insert only one SIM in either slot 0 or slot 1.
2. Check import and export page of contacts app.

* Expected Result
If SIM is in slot 0, user will see SIM 1 in import and export list.
If SIM is in slot 1, user will see SIM 2 in import and export list.

* Actual Result
If SIM is in slot 0, user will see SIM 1 in import and export list.
If SIM is in slot 1, user still sees SIM 1 in import and export list.

* Occurrence rate
100%
blocking-b2g: --- → 1.3?
Whiteboard: [dsds_US_test]
Is the device working now just one sim?

Nice, I can try to reproduce then.

Cheers,
F.
(In reply to Francisco Jordano [:arcturus] from comment #2)
> Is the device working now just one sim?
> 
> Nice, I can try to reproduce then.
> 
> Cheers,
> F.

Telephony part is abnormal, but I found that I can still export contact to SIM 2 even there is only SIM 1 I can select. So I still file this bug.
Blocks: 927893
Blocks: 923629
land when ready and ask for approval
blocking-b2g: 1.3? → -
(In reply to Wilfred Mathanaraj [:WDM] from comment #4)
> land when ready and ask for approval

Hi Wilfred,

Could you elaborate more about why not set it in 1.3? now? It's 1.3 user story.
Flags: needinfo?(wmathanaraj)
Contact import work and user is not stopped from importing. We can fix the display of the right SIM number in v1.4. Hence we removed the 1.3?.

Also if you have fixed in and someone wants to cherry pick this item then they can do for v1.3.
Flags: needinfo?(wmathanaraj)
(In reply to Wilfred Mathanaraj [:WDM] from comment #6)
> Contact import work and user is not stopped from importing. We can fix the
> display of the right SIM number in v1.4. Hence we removed the 1.3?.
> 
> Also if you have fixed in and someone wants to cherry pick this item then
> they can do for v1.3.

Hi Wilfred, sorry that I still do not fully understand why this can be pushed to v1.4. I think it's a huge UI mistake, why can we allow this to be fixed in next release?
blocking-b2g: - → 1.3?
Flags: needinfo?(wmathanaraj)
noemi - how much work would this be to fix this for v1.3?
Flags: needinfo?(wmathanaraj) → needinfo?(noef)
(In reply to Wilfred Mathanaraj [:WDM] from comment #8)
> noemi - how much work would this be to fix this for v1.3?

Hi, we take it for this sprint, target milestone updated
Assignee: nobody → francisco.jordano
Flags: needinfo?(noef)
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Status: NEW → ASSIGNED
triage: 1.3+
blocking-b2g: 1.3? → 1.3+
Attached file Pointer to PR 14654
Attachment #8347264 - Flags: review?(jmcf)
Pretty good points, I hope that I addressed all of them.

Thanks for the review!
No longer blocks: 923629
See Also: → 923629
No longer blocks: 927893
See Also: → 927893
Comment on attachment 8347264 [details] [review]
Pointer to PR 14654

I've left a final comment on GH about refactoring the sinon stub for mozIccManager. 

https://github.com/mozilla-b2g/gaia/pull/14654#discussion-diff-8429321R169

Apart from that, good work Francisco!
Attachment #8347264 - Flags: review?(jmcf) → review+
Landed:

https://github.com/mozilla-b2g/gaia/commit/44641af542c8a4fc507a7dc676083e93abf16976
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Uplifted 44641af542c8a4fc507a7dc676083e93abf16976 to:
v1.3: 2876290ce88a41c7c9d727f046dd6c0decfaef34
Verified on Fugu, passed.

Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.