944572 - [DSDS] Even if SIM card is in slot 1 which is SIM2, import and export function of Contacts app will still show SIM1 in the list.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Enpei]

Attachment: time stamp: 10:55, 11/29

No matter insert only one SIM in slot 0 or slot 1, system only shows SIM 1 in import and export page of Contacts app.

* Build Number                
Gaia:     53bd0adc20e83ccf718c6d2c2a3905efb14d1bef
Gecko:    f239e6a56a72096ac4aff3d4cd8fcc01ac9471b5
BuildID   20131129093923
Version   28.0a1

* Reproduce Steps
1. Insert only one SIM in either slot 0 or slot 1.
2. Check import and export page of contacts app.

* Expected Result
If SIM is in slot 0, user will see SIM 1 in import and export list.
If SIM is in slot 1, user will see SIM 2 in import and export list.

* Actual Result
If SIM is in slot 0, user will see SIM 1 in import and export list.
If SIM is in slot 1, user still sees SIM 1 in import and export list.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: Slot 0 with SIM, time stamp 10:58, 11/29.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Is the device working now just one sim?

Nice, I can try to reproduce then.

Cheers,
F.

Comment 3

[Enpei]

(In reply to Francisco Jordano [:arcturus] from comment #2)
> Is the device working now just one sim?
> 
> Nice, I can try to reproduce then.
> 
> Cheers,
> F.

Telephony part is abnormal, but I found that I can still export contact to SIM 2 even there is only SIM 1 I can select. So I still file this bug.

Comment 4

[Wilfred Mathanaraj [:WDM]]

land when ready and ask for approval

Comment 5

[Enpei]

(In reply to Wilfred Mathanaraj [:WDM] from comment #4)
> land when ready and ask for approval

Hi Wilfred,

Could you elaborate more about why not set it in 1.3? now? It's 1.3 user story.

Comment 6

[Wilfred Mathanaraj [:WDM]]

Contact import work and user is not stopped from importing. We can fix the display of the right SIM number in v1.4. Hence we removed the 1.3?.

Also if you have fixed in and someone wants to cherry pick this item then they can do for v1.3.

Comment 7

[Enpei]

(In reply to Wilfred Mathanaraj [:WDM] from comment #6)
> Contact import work and user is not stopped from importing. We can fix the
> display of the right SIM number in v1.4. Hence we removed the 1.3?.
> 
> Also if you have fixed in and someone wants to cherry pick this item then
> they can do for v1.3.

Hi Wilfred, sorry that I still do not fully understand why this can be pushed to v1.4. I think it's a huge UI mistake, why can we allow this to be fixed in next release?

Comment 8

[Wilfred Mathanaraj [:WDM]]

noemi - how much work would this be to fix this for v1.3?

Comment 9

[Noemí Freire (:noemi)]

(In reply to Wilfred Mathanaraj [:WDM] from comment #8)
> noemi - how much work would this be to fix this for v1.3?

Hi, we take it for this sprint, target milestone updated

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 14654

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Pretty good points, I hope that I addressed all of them.

Thanks for the review!

Comment 13

[Jose Manuel Cantera]

Comment on attachment 8347264 [details] [review]
Pointer to PR 14654

I've left a final comment on GH about refactoring the sinon stub for mozIccManager. 

https://github.com/mozilla-b2g/gaia/pull/14654#discussion-diff-8429321R169

Apart from that, good work Francisco!

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/44641af542c8a4fc507a7dc676083e93abf16976

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 44641af542c8a4fc507a7dc676083e93abf16976 to:
v1.3: 2876290ce88a41c7c9d727f046dd6c0decfaef34

Comment 16

[Enpei]

Verified on Fugu, passed.

Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2