Add capture permission to SYSTEM app to enable BOOKMARKED web pages acquires gUM.

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pauljt, Assigned: gasolin)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #916007 +++

Bug 916007 adds the the 'audio-capture' permission to the browser so that web pages can access the audio part of getUserMedia. Bookmarked web pages pinned to the homescreen however open in a mozbrowser window that is a child of the system app, not the browser. The system app doesn't have the 'audio-capture' permission, so this API always failed in a bookmarked page pinned to the homescreen.

Simple, low risk fix: just need to add:

"audio-capture": {},

to the system app manifest.

916007 was koi+ and this probably should be too.
Good catch - yeah, we need to fix this.
No longer blocks: 914028, 938962, 894848
(Assignee)

Updated

5 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 2

5 years ago
Created attachment 8340270 [details] [review]
pull request redirect to github

only add audio permission since it suppose to be uplift to 1.2

will add video permission in another bug
Attachment #8340270 - Flags: review?(alive)
(Assignee)

Updated

5 years ago
Blocks: 944632
Attachment #8340270 - Flags: review?(alive) → review+
(Assignee)

Comment 3

5 years ago
Merged to gaia master https://github.com/mozilla-b2g/gaia/commit/cfdbdf29af3226d505bdc72ad9cf2ab812685251
Thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+

Comment 4

5 years ago
Just for clarity: this still prompts the user, right?

Updated

5 years ago
Keywords: verifyme
QA Contact: jsmith
(Assignee)

Comment 5

5 years ago
Eric, if you mean user still see a permission dialog when the bookmark page require gUM, yes
Uplifted cfdbdf29af3226d505bdc72ad9cf2ab812685251 to:
v1.2: 26e7d73f4bb9198205f70b53daab9ffd11aaac21
status-b2g-v1.2: --- → fixed
Verified on 12/12/2013 Buri 1.2 build.
status-b2g-v1.2: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.