Closed
Bug 944592
Opened 11 years ago
Closed 11 years ago
[Bluetooth] Re-implement BluetoothOppManager::Disconnect()
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 6 - 12/6
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
Attachments
(1 file)
|
6.42 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
Bug 937572 replaces all Disconnect() in BluetoothOppManager, but still BluetoothService calls BluetoothOppManager::Disconnect() in StartStopBluetooth. Therefore this bug moves back socket disconnection back to Disconnect(), otherwise crash happens on debug build when BT stops during file transferring.
|
Assignee | |
Comment 1•11 years ago
|
||
Fix for both bluez & bluedroid.
Assignee: nobody → btian
Attachment #8340238 -
Flags: review?(echou)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8340238 [details] [diff] [review]
[final] Patch 1: Re-implement BluetoothOppManager::Disconnect(), r=echou
Review of attachment 8340238 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8340238 -
Flags: review?(echou) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8340238 -
Attachment description: Patch 1 (v1): Re-implement BluetoothOppManager::Disconnect() → [final] Patch 1: Re-implement BluetoothOppManager::Disconnect(), r=echou
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in
before you can comment on or make changes to this bug.
Description
•