944601 - [Settings] Enter wrong PIN code twice and then enter the correct code. There's still "Last try" left on the screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Al Tsai [:atsai]]

Attachment: 2013-11-29-14-38-28.png

Enter wrong PIN code twice and then enter the correct code. There's still "Last try" left on the screen

[STR]
1. Launch settings -> SIM Security
2. Toggle "SIM PIN"
3. Enter wrong PIN code twice
4. Enter correct PIN code
5. Toggle "SIM PIN"

[Expected Result]
5. the same page as in step 2

[Actual Result]
5. "last try on the page" - check the attachment

[Environment]
DuT:      Buri
Gaia:     0d57ec2801ae125ec855a19cf956ab118660d694
Gecko:    http://hg.mozilla.org/mozilla-central/rev/a5e7f611546f
BuildID   20131128040201
Version   28.0a1
ro.build.version.incremental=eng.archermind.20131114.105818

Comment 1

[Al Tsai [:atsai]]

nom 1.3? to fix in v1.3 branch.
It could confuse users, if there's a "last try" label on the page.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Al Tsai [:atsai] from comment #1)
> It could confuse users, if there's a "last try" label on the page.

Triage: agree with estimation above.

Comment 3

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 4

[Peter Bylenga [:PBylenga]]

This issue reproduces on 1.2 I see the text "last try" when toggling SIM to enabled after successfully disabling it on the third try.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131219004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/7958c38c7afd
Gaia: c82c957e9d4078cd4043de6b7d21a2667a73adf7
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: 20131115

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kaze, are you working on this?

Comment 6

[Fabien Cazenave [:kaze]]

It’s on top of my list now.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kaze, do you need any help?

Comment 8

[Fabien Cazenave [:kaze]]

I’m going to finish this item today, hopefully. Following our discussion on IRC, I’ll unassign myself if I can’t make it before Monday.

Comment 9

[Fabien Cazenave [:kaze]]

Attachment: patch

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8361488 [details] [review]
patch

Please see my comments in github, thanks!

Comment 12

[Wilfred Mathanaraj [:WDM]]

PM reviewed agreed on block release

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

The root cause is that we are not able to get the retry count in advance. We should display correct messages when showing pin dialog based on the retry count instead of hiding the message by default.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Steal the bug. And please ignore comment 13. The root cause should be we are not using the API properly. getCardLockRetryCount returns a dom request.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/15588

Evelyn, could you help review the patch? Thanks!

Comment 17

[Evelyn Hung]

Comment on attachment 8363529 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15588

r=me, thanks!!

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 07228fa77cd194f06cf647d1281c35827c367684

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 07228fa77cd194f06cf647d1281c35827c367684 to:
v1.3: 92a6a646f9e021facdf409fd2af0e5793bffbb4f

Comment 20

[Enpei]

Verified.

Fugu - 
Gaia      bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko     4227240a4d3e1e418ced160c2a48cb454d7b5645
BuildID   20140204104742
Version   28.0

Comment 21

[Michael Henretty [:mikehenrty][:mhenretty]]

I have a question about this fix. I need to do something similar for bug 966571 (but in system and ftu), but it seems I cannot test on device since this method (icc.getCardLockRetryCount) is not supported in MOZ ril, and we don't have any RIL's that do for 1.3. So how can I verify that getCardLockRetryCount is working as intended?

https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#705

Comment 22

[Michael Henretty [:mikehenrty][:mhenretty]]

Sorry, didn't mean to flag Enpei, this is more to the developers who worked on this patch.

Comment 23

[Michael Henretty [:mikehenrty][:mhenretty]]

NM, I needed only to look 3 lines up https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#700, I need to use the emulator. Sorry about the bugmail spam.