944610 - Enable "Close Tabs to the right" tab context menu on a pinned tab

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

# environment
* http://hg.mozilla.org/mozilla-central/rev/3c44c1f43a67

The current Firefox's codebase does not allow that enable "Close Tabs to the right" tab context menu on a pinned tab. This is not useful to close all normal tabs without pinned tabs.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch v1

Gavin, how about this?

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I tried browser-chrome tests: https://tbpl.mozilla.org/?tree=Try&rev=86d5ff85e4d8

Comment 3

[:Gavin Sharp [email: [e-mail]]]

"Close tabs to the right" magically skipping tabs to the right that are app tabs seems confusing.

I'm inclined to say this is WONTFIX, because I don't think "close all non-app tabs" is that important enough of a use case (and can be achieved in other ways, e.g. by holding down Cmd+W) but please feel free to raise this with folks on the UX team on fx-desktop to discuss other alternatives.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to :Gavin Sharp (email [e-mail]) from comment #3)
> "Close tabs to the right" magically skipping tabs to the right that are app
> tabs seems confusing.
> 
> I'm inclined to say this is WONTFIX, because I don't think "close all
> non-app tabs" is that important enough of a use case (and can be achieved in
> other ways, e.g. by holding down Cmd+W) but please feel free to raise this
> with folks on the UX team on fx-desktop to discuss other alternatives.


In the situation which use a feed reader in pinned tab & open all feed links as normal tabs, I want this "Close tabs to the right" features. "Close tabs to the right" on a pinned tab is very useful like this cases opening many tabs from pinned tab.

I don't think this proposed behavior is not magically because a pinned tabs are "pinned" to not close easily, to display always. In Firefox, we cannot close it without using "Close Tab" from tab context menu on them.

Should I post proposal firefox-dev ML to discuss?

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Comment on attachment 8340246 [details] [diff] [review]
patch v1

Jared, how do you think about this change?

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch v2

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I agree with Gavin. This would only be less confusing when it appears on the right-most pinned tab, but showing context menu items based on tab positions may not be obvious. I'd agree with Gavin that this should not be changed.