944662 - Set one of the Bulgarian Input Method as default keyboard for Bulgarian language

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #936840 +++

This is a follow-up to modify shared/resources/keyboard_layouts.json so that one of the Bulgarian IME would be set as the default keyboard when the language is changed to Bulagrian.

Besides, since Bulgarian is a non-latin language (?), I think English layout should be enabled as well.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

This patch is set the default keyboard layout used by the system when the user language (OS UI language) is changed.

Hi  Mihail,

Do you think it is ok to set bg-BDS only as the default keyboard layout for Bulgarian?
Thanks.

Comment 2

[Mihail Chilyashev]

Comment on attachment 8340313 [details] [review]
Patch V1

Hello Rudy,

Yes, I think it's OK since the other layouts will be available.


Thank you.

Comment 3

[Mihail Chilyashev]

Comment on attachment 8340313 [details] [review]
Patch V1

Hello again,

I still can't edit the flags of the attachment, so please consider the feedback granted.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

What's the status of this bug? Did you forget to set assignee to yourself?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yeah, seems this is lost in my tracking.
Will submit an updated patch later.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

layout mapping config update.

Jan, could you help review this simple change?
Thanks.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8516455 [details] [review]
Patch V1

I'm pretty sure the en & bg lines should be other way around, now en is default layout and bg is secondary.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8516455 [details] [review]
Patch V1

I think the order should be irrelevant, since we could not change the order of layouts, it is always the same order as how we preload them.

But anyway, to sync with the other languages, I changed it as you suggests.
Thanks.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8516455 [details] [review]
Patch V1

r=me

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

master,
https://github.com/mozilla-b2g/gaia/commit/726c83231f74d7145d66f25af4b97908a0d8ad6f

--
Thanks.