944685 - B2G Desktop looks pixelized on retina display

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Paul Rouget [:paul]]

B2G Desktop is rendered in low resolution.

Comment 1

[Paul Rouget [:paul]]

Attachment: v1

Who can review that?

Comment 2

[Paul Rouget [:paul]]

Attachment: screenshot before after

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 8340348 [details] [diff] [review]
v1

Gavin, you wrote the first version of the plist file. Maybe you can review this patch.

Comment 4

[Markus Stange [:mstange] (on PTO, back July 5)]

Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what we use in the normal Firefox app bundle, and with that we probably don't even need NSHighResolutionCapable. But let's set it anyway to be consistent with bug 898588.

Comment 5

[Paul Rouget [:paul]]

Attachment: v2

Comment 6

[Paul Rouget [:paul]]

(In reply to Markus Stange [:mstange] from comment #4)
> Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what
> we use in the normal Firefox app bundle, and with that we probably don't
> even need NSHighResolutionCapable. But let's set it anyway to be consistent
> with bug 898588.

Thanks Markus. Can you recommend a reviewer?

Comment 7

[Markus Stange [:mstange] (on PTO, back July 5)]

Comment on attachment 8340448 [details] [diff] [review]
v2

Myself? :)
If Gavin's fine with it, of course.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Markus Stange [:mstange] from comment #7)
> If Gavin's fine with it, of course.

Is he? :)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

I did not write this file originally (I suspect blame misled or lied to you), Markus is a much better reviewer than I.

(It seems strange to have the b2g plist differ from Desktop re: NSHighResolutionCapable, but whatever)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e5fc3b78daa0

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5fc3b78daa0