B2G Desktop looks pixelized on retina display

RESOLVED FIXED in mozilla28

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

unspecified
mozilla28
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
B2G Desktop is rendered in low resolution.
(Assignee)

Comment 1

4 years ago
Created attachment 8340348 [details] [diff] [review]
v1

Who can review that?
Assignee: nobody → paul
Attachment #8340348 - Flags: review?
(Assignee)

Comment 2

4 years ago
Created attachment 8340349 [details]
screenshot before after
(Assignee)

Comment 3

4 years ago
Comment on attachment 8340348 [details] [diff] [review]
v1

Gavin, you wrote the first version of the plist file. Maybe you can review this patch.
Attachment #8340348 - Flags: review? → review?(gavin.sharp)
Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what we use in the normal Firefox app bundle, and with that we probably don't even need NSHighResolutionCapable. But let's set it anyway to be consistent with bug 898588.
(Assignee)

Comment 5

4 years ago
Created attachment 8340448 [details] [diff] [review]
v2
(Assignee)

Comment 6

4 years ago
(In reply to Markus Stange [:mstange] from comment #4)
> Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what
> we use in the normal Firefox app bundle, and with that we probably don't
> even need NSHighResolutionCapable. But let's set it anyway to be consistent
> with bug 898588.

Thanks Markus. Can you recommend a reviewer?
Comment on attachment 8340448 [details] [diff] [review]
v2

Myself? :)
If Gavin's fine with it, of course.
Attachment #8340448 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(In reply to Markus Stange [:mstange] from comment #7)
> If Gavin's fine with it, of course.

Is he? :)
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Attachment #8340448 - Flags: review?(gavin.sharp)
(Assignee)

Updated

4 years ago
Attachment #8340348 - Attachment is obsolete: true
Attachment #8340348 - Flags: review?(gavin.sharp)
Attachment #8340448 - Flags: review?(gavin.sharp)
I did not write this file originally (I suspect blame misled or lied to you), Markus is a much better reviewer than I.

(It seems strange to have the b2g plist differ from Desktop re: NSHighResolutionCapable, but whatever)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/e5fc3b78daa0
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5fc3b78daa0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.