Status
()
People
(Reporter: paul, Assigned: paul)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments, 1 obsolete attachment)
|
1.49 MB,
image/png
|
Details | |
|
702 bytes,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
screenshot before after
B2G Desktop is rendered in low resolution.
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 8340348 [details] [diff] [review] v1 Who can review that?
Assignee: nobody → paul
Attachment #8340348 -
Flags: review?
|
|
(Assignee) | |
Comment 2•5 years ago
|
||
Created attachment 8340349 [details] screenshot before after
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
Comment on attachment 8340348 [details] [diff] [review] v1 Gavin, you wrote the first version of the plist file. Maybe you can review this patch.
Attachment #8340348 -
Flags: review? → review?(gavin.sharp)
|
||
Comment 4•5 years ago
|
||
Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what we use in the normal Firefox app bundle, and with that we probably don't even need NSHighResolutionCapable. But let's set it anyway to be consistent with bug 898588.
|
|
(Assignee) | |
Comment 5•5 years ago
|
||
Created attachment 8340448 [details] [diff] [review] v2
|
|
(Assignee) | |
Comment 6•5 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #4) > Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what > we use in the normal Firefox app bundle, and with that we probably don't > even need NSHighResolutionCapable. But let's set it anyway to be consistent > with bug 898588. Thanks Markus. Can you recommend a reviewer?
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 8340448 [details] [diff] [review] v2 Myself? :) If Gavin's fine with it, of course.
Attachment #8340448 -
Flags: review+
|
|
(Assignee) | |
Updated•5 years ago
|
Keywords: checkin-needed
|
||
Comment 8•5 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #7) > If Gavin's fine with it, of course. Is he? :)
Keywords: checkin-needed
|
|
(Assignee) | |
Updated•5 years ago
|
Attachment #8340448 -
Flags: review?(gavin.sharp)
|
|
(Assignee) | |
Updated•5 years ago
|
Attachment #8340348 -
Attachment is obsolete: true
Attachment #8340348 -
Flags: review?(gavin.sharp)
|
||
Updated•5 years ago
|
Attachment #8340448 -
Flags: review?(gavin.sharp)
|
|
||
Comment 9•5 years ago
|
||
I did not write this file originally (I suspect blame misled or lied to you), Markus is a much better reviewer than I. (It seems strange to have the b2g plist differ from Desktop re: NSHighResolutionCapable, but whatever)
|
|
(Assignee) | |
Updated•5 years ago
|
Keywords: checkin-needed
|
|
||
Comment 10•5 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/e5fc3b78daa0
Keywords: checkin-needed
|
||
Comment 11•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5fc3b78daa0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•