Closed Bug 944685 Opened 7 years ago Closed 7 years ago

B2G Desktop looks pixelized on retina display

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(2 files, 1 obsolete file)

B2G Desktop is rendered in low resolution.
Attached patch v1 (obsolete) — Splinter Review
Who can review that?
Assignee: nobody → paul
Attachment #8340348 - Flags: review?
Attached image screenshot before after
Comment on attachment 8340348 [details] [diff] [review]
v1

Gavin, you wrote the first version of the plist file. Maybe you can review this patch.
Attachment #8340348 - Flags: review? → review?(gavin.sharp)
Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what we use in the normal Firefox app bundle, and with that we probably don't even need NSHighResolutionCapable. But let's set it anyway to be consistent with bug 898588.
Attached patch v2Splinter Review
(In reply to Markus Stange [:mstange] from comment #4)
> Can you also set NSPrincipalClass = GeckoNSApplication, please? That's what
> we use in the normal Firefox app bundle, and with that we probably don't
> even need NSHighResolutionCapable. But let's set it anyway to be consistent
> with bug 898588.

Thanks Markus. Can you recommend a reviewer?
Comment on attachment 8340448 [details] [diff] [review]
v2

Myself? :)
If Gavin's fine with it, of course.
Attachment #8340448 - Flags: review+
Keywords: checkin-needed
(In reply to Markus Stange [:mstange] from comment #7)
> If Gavin's fine with it, of course.

Is he? :)
Keywords: checkin-needed
Attachment #8340448 - Flags: review?(gavin.sharp)
Attachment #8340348 - Attachment is obsolete: true
Attachment #8340348 - Flags: review?(gavin.sharp)
Attachment #8340448 - Flags: review?(gavin.sharp)
I did not write this file originally (I suspect blame misled or lied to you), Markus is a much better reviewer than I.

(It seems strange to have the b2g plist differ from Desktop re: NSHighResolutionCapable, but whatever)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5fc3b78daa0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.