Closed Bug 944697 Opened 11 years ago Closed 6 years ago

Tests consistently fail on retina

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: daleharvey, Assigned: etienne)

Details

Attachments

(1 file)

Gaia PR
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
These 3 failures are consistent fails on OSX with 10.9 retina display, they do not fail on my 10.8.4 non retina (not on travis et al)

1) Edges gesture > Swiping between apps left to right:
     
  AssertionError: sms is invisible
      at Context.<anonymous> (/Volumes/firefoxos/gaia/apps/system/test/marionette/edges_gesture_test.js:46:5)
      at Test.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:211:32)
      at Runner.runTest (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:355:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:401:12
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:281:14)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:290:7
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:234:23)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at Hook.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:213:5)
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:246:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at done (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:185:5)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:197:9
      at Object.executeHook (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)
      at process._tickCallback (node.js:415:13)

  2) Edges gesture > Swiping between apps right to left:
     
  Error: timeout exceeded!
      at Object.Client.waitForSync (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:679:16)
      at Object.Client.waitFor (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)
      at edgeSwipeToApp (/Volumes/firefoxos/gaia/apps/system/test/marionette/edges_gesture_test.js:39:12)
      at Context.<anonymous> (/Volumes/firefoxos/gaia/apps/system/test/marionette/edges_gesture_test.js:63:5)
      at Test.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:211:32)
      at Runner.runTest (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:355:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:401:12
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:281:14)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:290:7
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:234:23)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at Hook.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:213:5)
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:246:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at done (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:185:5)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:197:9
      at Object.executeHook (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)
      at process._tickCallback (node.js:415:13)

  3) Edges gesture > Swiping vertically:
     
  Error: timeout exceeded!
      at Object.Client.waitForSync (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:679:16)
      at Object.Client.waitFor (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)
      at edgeSwipeToApp (/Volumes/firefoxos/gaia/apps/system/test/marionette/edges_gesture_test.js:39:12)
      at Context.<anonymous> (/Volumes/firefoxos/gaia/apps/system/test/marionette/edges_gesture_test.js:84:5)
      at Test.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:211:32)
      at Runner.runTest (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:355:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:401:12
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:281:14)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:290:7
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:234:23)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at Hook.Runnable.run (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:213:5)
      at next (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:246:10)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runner.js:253:7
      at done (/Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:185:5)
      at /Volumes/firefoxos/gaia/node_modules/mocha/lib/runnable.js:197:9
      at Object.executeHook (/Volumes/firefoxos/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)
      at process._tickCallback (node.js:415:13)
Moving to system app because I see the word system but not the word email.
Component: Gaia::E-Mail → Gaia::System
Attached file Gaia PR — 
Hey Dale, does this help ?
Assignee: nobody → etienne
Attachment #8350060 - Flags: feedback?(dale)
Comment on attachment 8350060 [details] [review]
Gaia PR

We probably want to do this anyway and travis is happy so flagging for review in parallel.
Attachment #8350060 - Flags: review?(alive)
Comment on attachment 8350060 [details] [review]
Gaia PR

Byebye hardcode!
Attachment #8350060 - Flags: review?(alive) → review+
Comment on attachment 8350060 [details] [review]
Gaia PR

asking for r? again because I added Vivien's suggestion of properly using clientX/clientY instead of screenX/screenY.
Attachment #8350060 - Flags: review+ → review?(alive)
Comment on attachment 8350060 [details] [review]
Gaia PR

r+ again
Attachment #8350060 - Flags: review?(alive) → review+
Comment on attachment 8350060 [details] [review]
Gaia PR

Hey Alive,

Sorry for asking for review 3 times, but I have a new version :)
Thanks to Kevin's gist [1] I was able to really beat on the test and we now have a version that seems bullet-proof (100+ successive greens).

Thanks!

[1] https://gist.github.com/KevinGrandon/8047042
Attachment #8350060 - Flags: review?(alive)
Attachment #8350060 - Flags: review+
Attachment #8350060 - Flags: feedback?(dale)
Comment on attachment 8350060 [details] [review]
Gaia PR

I feel I am educated ;)
Attachment #8350060 - Flags: review?(alive) → review+
Landed! (Rik confirmed that it was working on Retina macs too :))

https://github.com/mozilla-b2g/gaia/commit/8baebf8560695b7805f88955db59400a838c8328
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reverted for making the Gaia Integration tests perma-fail on TBPL.
https://github.com/mozilla-b2g/gaia/commit/f96550818241030c3abb3d3e2de5769fda1b8455

https://tbpl.mozilla.org/php/getParsedLog.php?id=32649099&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ha. fun :)

Gareth, is there a way to trigger tbpl try builds for a gaia patch?
Flags: needinfo?(gaye)
Sadly not yet, Etienne... see https://bugzilla.mozilla.org/show_bug.cgi?id=914632.
Flags: needinfo?(gaye)
I'm seeing this one too. All tests fail on the onbefore hook.

Test output for the first failure observed:

1) Awesomescreen "before each" hook:

Error: could not find an app with the origin: "app://browser.gaiamobile.org"
      at /Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/getapp.js:59:9
      at Object.<anonymous> (/Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/mgmt.js:58:14)
      at Object.Client._handleCallback (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:482:23)
      at /Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:508:21
      at TcpSync.send (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)
      at Object.send (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:455:36)
      at Object.Client._sendCommand (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:501:19)
      at Object._executeScript (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:1448:19)
      at Object.executeAsyncScript (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:1229:19)
      at Object.Mgmt.getAll (/Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/mgmt.js:37:19)
      at list (/Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/list.js:14:20)
      at getApp (/Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/getapp.js:45:10)
      at launch (/Users/alacroix/Projects/gaia/node_modules/marionette-apps/lib/launch.js:40:10)
      at Object.Browser.launch (/Users/alacroix/Projects/gaia/apps/browser/test/marionette/lib/browser.js:91:22)
      at Context.<anonymous> (/Users/alacroix/Projects/gaia/apps/browser/test/marionette/awesomescreen_test.js:10:13)
      at Hook.Runnable.run (/Users/alacroix/Projects/gaia/node_modules/mocha/lib/runnable.js:211:32)
      at next (/Users/alacroix/Projects/gaia/node_modules/mocha/lib/runner.js:257:10)
      at /Users/alacroix/Projects/gaia/node_modules/mocha/lib/runner.js:269:7
      at done (/Users/alacroix/Projects/gaia/node_modules/mocha/lib/runnable.js:185:5)
      at /Users/alacroix/Projects/gaia/node_modules/mocha/lib/runnable.js:197:9
      at Object.executeHook (/Users/alacroix/Projects/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)
      at process._tickCallback (node.js:415:13)
with $ REPORTER=spec APP=system make test-integration I am seeing http://pastie.org/8634017
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 10 years ago → 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: