944703 - Use RefPtr instead of raw pointers to store pointers to ISurfaceAllocator's

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

We've had a lot of crashes due to dangling ISurfaceAllocator* pointers.

ISurfaceAllocator was recently made reference-counted (bug 933082), so we shouldn't need to store raw ISurfaceAllocator* pointers long-term anymore.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 1: make SurfaceCaps hold a strong reference to its ISurfaceAllocator

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 2: make gfxReusableSharedImageSurfaceWrapper hold a strong reference to its ISurfaceAllocator

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 3: make TextureHost hold a strong reference to its ISurfaceAllocator

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 4: make ContentHost hold a strong reference to its ISurfaceAllocator

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 5: make AllocShmemParams hold a strong reference to its ISurfaceAllocator

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 6: make DeprecatedSharedPlanarYCbCrImage hold a strong reference to its ISurfaceAllocator

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 7: make DeprecatedSharedRGBImage hold a strong reference to its ISurfaceAllocator

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 8: make ShmemTextureClient hold a strong reference to its ISurfaceAllocator

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=7fc03419b3a8

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

On Windows:
https://tbpl.mozilla.org/?tree=Try&rev=d586c5350e79

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=eb3be360fb34

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=1b48093b8244

Comment 13

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=01672e3e55a0

http://hg.mozilla.org/integration/mozilla-inbound/rev/101f294ad43c
http://hg.mozilla.org/integration/mozilla-inbound/rev/781892a439cf
http://hg.mozilla.org/integration/mozilla-inbound/rev/aa7869e65cc8
http://hg.mozilla.org/integration/mozilla-inbound/rev/30a25eb71609
http://hg.mozilla.org/integration/mozilla-inbound/rev/58b167ccb8e6
http://hg.mozilla.org/integration/mozilla-inbound/rev/31859d96678a
http://hg.mozilla.org/integration/mozilla-inbound/rev/cace22d26591
http://hg.mozilla.org/integration/mozilla-inbound/rev/d00ad4010be8

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/101f294ad43c
https://hg.mozilla.org/mozilla-central/rev/781892a439cf
https://hg.mozilla.org/mozilla-central/rev/aa7869e65cc8
https://hg.mozilla.org/mozilla-central/rev/30a25eb71609
https://hg.mozilla.org/mozilla-central/rev/58b167ccb8e6
https://hg.mozilla.org/mozilla-central/rev/31859d96678a
https://hg.mozilla.org/mozilla-central/rev/cace22d26591
https://hg.mozilla.org/mozilla-central/rev/d00ad4010be8