Use RefPtr instead of raw pointers to store pointers to ISurfaceAllocator's

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(8 attachments)

3.33 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review
2.46 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
3.48 KB, patch
nical
: review+
Details | Diff | Splinter Review
815 bytes, patch
nical
: review+
Details | Diff | Splinter Review
793 bytes, patch
nical
: review+
Details | Diff | Splinter Review
2.47 KB, patch
nical
: review+
Details | Diff | Splinter Review
707 bytes, patch
nical
: review+
Details | Diff | Splinter Review
663 bytes, patch
nical
: review+
Details | Diff | Splinter Review
We've had a lot of crashes due to dangling ISurfaceAllocator* pointers.

ISurfaceAllocator was recently made reference-counted (bug 933082), so we shouldn't need to store raw ISurfaceAllocator* pointers long-term anymore.
Attachment #8340388 - Flags: review?(nical.bugzilla) → review+
Attachment #8340389 - Flags: review?(nical.bugzilla) → review+
Attachment #8340390 - Flags: review?(nical.bugzilla) → review+
Attachment #8340393 - Flags: review?(nical.bugzilla) → review+
Attachment #8340394 - Flags: review?(nical.bugzilla) → review+
Attachment #8340395 - Flags: review?(nical.bugzilla) → review+
Attachment #8340387 - Flags: review?(bgirard) → review+
Attachment #8340385 - Flags: review?(jgilbert) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.