Closed
Bug 944703
Opened 9 years ago
Closed 9 years ago
Use RefPtr instead of raw pointers to store pointers to ISurfaceAllocator's
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
(Whiteboard: [qa-])
Attachments
(8 files)
3.33 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
2.46 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
3.48 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
815 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
793 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
2.47 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
707 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
663 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
We've had a lot of crashes due to dangling ISurfaceAllocator* pointers. ISurfaceAllocator was recently made reference-counted (bug 933082), so we shouldn't need to store raw ISurfaceAllocator* pointers long-term anymore.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8340385 -
Flags: review?(jgilbert)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8340387 -
Flags: review?(bgirard)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8340388 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8340389 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8340390 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8340393 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8340394 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8340395 -
Flags: review?(nical.bugzilla)
Updated•9 years ago
|
Attachment #8340388 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8340389 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8340390 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8340393 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8340394 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8340395 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7fc03419b3a8
Updated•9 years ago
|
Attachment #8340387 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 10•9 years ago
|
||
On Windows: https://tbpl.mozilla.org/?tree=Try&rev=d586c5350e79
Updated•9 years ago
|
Attachment #8340385 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 11•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=eb3be360fb34
Assignee | ||
Comment 12•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=1b48093b8244
Assignee | ||
Comment 13•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=01672e3e55a0 http://hg.mozilla.org/integration/mozilla-inbound/rev/101f294ad43c http://hg.mozilla.org/integration/mozilla-inbound/rev/781892a439cf http://hg.mozilla.org/integration/mozilla-inbound/rev/aa7869e65cc8 http://hg.mozilla.org/integration/mozilla-inbound/rev/30a25eb71609 http://hg.mozilla.org/integration/mozilla-inbound/rev/58b167ccb8e6 http://hg.mozilla.org/integration/mozilla-inbound/rev/31859d96678a http://hg.mozilla.org/integration/mozilla-inbound/rev/cace22d26591 http://hg.mozilla.org/integration/mozilla-inbound/rev/d00ad4010be8
Assignee: nobody → bjacob
Target Milestone: --- → mozilla28
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/101f294ad43c https://hg.mozilla.org/mozilla-central/rev/781892a439cf https://hg.mozilla.org/mozilla-central/rev/aa7869e65cc8 https://hg.mozilla.org/mozilla-central/rev/30a25eb71609 https://hg.mozilla.org/mozilla-central/rev/58b167ccb8e6 https://hg.mozilla.org/mozilla-central/rev/31859d96678a https://hg.mozilla.org/mozilla-central/rev/cace22d26591 https://hg.mozilla.org/mozilla-central/rev/d00ad4010be8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•