Closed Bug 944725 Opened 6 years ago Closed 6 years ago

B2G RIL: const the error message returned by icc.read/updateContact.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.3 Sprint 6 - 12/6

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(2 files, 4 obsolete files)

We should make the error message returned icc.read/updateContact more consistent.
Maybe const them into ril_const.js.
Assignee: nobody → allstars.chh
Add tests for PIN2 and ICC IO Error.
And update the marionette test as well.
Attachment #8341589 - Attachment is obsolete: true
Comment on attachment 8341588 [details] [diff] [review]
Part 1: unify errorMsg in icc.read/updateContacts.

Review of attachment 8341588 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +11166,3 @@
>      // See GSM11.11, TS 51.011 clause 9.4, and ISO 7816-4 for the error
>      // description.
>      let errorMsg = "ICC I/O Error code " +

nit: brace all errorMsg related lines with DEBUG.
Attachment #8341588 - Flags: review?(vyang) → review+
Attachment #8341640 - Flags: review?(vyang) → review+
move errorMsg inside processICCIOError into if (DEBUG)
Attachment #8341588 - Attachment is obsolete: true
Attachment #8342116 - Flags: review+
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #7)
> https://hg.mozilla.org/integration/b2g-inbound/rev/deaef09b17c1
> https://hg.mozilla.org/integration/b2g-inbound/rev/82345b162c51

sorry, had to backout this change since this caused a bustage in marionette-webapi tests like https://tbpl.mozilla.org/php/getParsedLog.php?id=31431202&tree=B2g-Inbound
Oh, it seems I push the older patch in Comment 7.

Sorry for the trouble here.
Comment on attachment 8341640 [details] [diff] [review]
Part 2: add xpcshell-tests for tesring returned errorMsg. v2

Review of attachment 8341640 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1959,5 @@
> +  USIM_PBR_FIELDS.push("pbc");
> +  do_test({contactType: "adn", contact: {contactId: ICCID + "1"}},
> +          CONTACT_ERR_FIELD_NOT_SUPPORTED);
> +
> +  // Error 7, EF_PBR doesn't exist.

Typo here, should be Error 8.
https://hg.mozilla.org/mozilla-central/rev/aa1af723d28d
https://hg.mozilla.org/mozilla-central/rev/1d8604c150e7
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
Blocks: 968550
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.