944758 - Add an Open Street Maps attribution

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Mapbox uses OSM data, and the terms of OSM data require us to mention them. Here is their specific guidance:

http://www.openstreetmap.org/copyright

I really like the way Github does this (see top right corner):

https://github.com/smartchicago/chicago-atlas/blob/master/db/import/zipcodes.geojson

However, for our purposes, the way the National Park Service does it is just as good, and a lot easier since we already have the translucent overlay:

http://www.nps.gov/npmap/park-tiles/

Suggestion: Add text to the translucent overlay on our maps.
Content: "<a>OpenStreetMap</a> Contributors" 
Link to: http://openstreetmap.org/copyright

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

Update: The content should include an ©

© OpenStreetMap contributors

Comment 2

[John Giannelos [:nemo-yiannis]]

When we first added the mapbox tiles I followed these instructions about OSM attribution [1].
In our case, we are using "L.mapbox.map()" which adds attribution automatically and I assume that's
that [2] link in bottom-right corner in our maps.

I have opened a PR here [3] that provides attribution to OSM more explicitly.
Do we want to keep the previous version or proceed with the changed in the PR?

[1] https://www.mapbox.com/help/#attribution
[2] http://mapbox.com/about/maps
[3] https://github.com/mozilla/remo/pull/557

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

For now I think we should deploy a PR to directly credit OSM as specified in their copyright:

http://www.openstreetmap.org/copyright

See Bug 944750 for more information and code.

If I get more information I will update this bug.

Comment 4

[John Giannelos [:nemo-yiannis]]

I see that bug 945318 is resolved but I am not authorized to see any details.
Do we have any updates on that?

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

:nemo, sorry! Yes, the solution in Bug 944750 is the right solution. If the same code works, great! If not, just make sure it has the same text/links as http://www.mozilla.org/en-US/contact/spaces/.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/b588797b8abcf35a132e1cb74aae48d2f763f714
[Fix bug 944758] Provide attribution to OpenStreetMap data.

https://github.com/mozilla/remo/commit/9ac3f34a4562cb6f161ca5497d7d4ba221717c07
Merge pull request #557 from johngian/944758-osm-attribution

[Fix bug 944758] Provide attribution to OpenStreetMap data.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/f2c8b1ef87a762bb4f6cc933eac2d5acd6c4a82c
[bug 944758] We must link to OSM copyright page.

https://github.com/mozilla/remo/commit/b3a916b4c577273380d8c5e7cc791173938f2e71
Merge pull request #578 from glogiotatidis/master

[bug 944758] We must link to OSM copyright page.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Verified on stage, attribution on map:
 * on /people page
 * on /events page
 * on new event page
 * on new ng-report page (the new reports)
 * on edit profile page
 * on event view page


Verified on stage, attribution at the end of the page:
 * on report view page 
 * on profile

Thanks :nemo!