944796 - [e.me][system] Use correct "X" to clear input fields.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Patryk Adamczyk [:patryk] UX]

E.Me and the system input use different "x"s clear. We should use the same "x" in every clear input field.
Amy will provide a screenshot for each instance in the system and then we'll provide a unified icon design for white and dark instances.

Comment 1

[Amy Lee [:amylee] UX]

Attachment: Clear_Icon_Assets.zip

Hi, 

Attached is the new clear icon that needs to be replaced in all text fields. I've attached screenshots of where it needs to be replaced and a mock of a few sample screens of what is currently there and what it should look like.

Ran, can you replace the clear textfield icon in the everything.me app and Pavel can you handle the rest? 

Thanks!

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Bug 944068 is unrelated as it has no clear button.
Of course it's relevant to the E.me searchbar.

Comment 3

[Patryk Adamczyk [:patryk] UX]

Attachment: clear input field button in e.me

Comment 4

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

see screenshots

Comment 5

[Amir Nissim (:amirn)]

Attachment: screenshot-before.png

Comment 6

[Amir Nissim (:amirn)]

Attachment: screenshot-after.png

Comment 7

[Patryk Adamczyk [:patryk] UX]

(In reply to Amir Nissim (Everything.me) from comment #6)
> Created attachment 8342415 [details]
> screenshot-after.png

Looks good! Ship it!

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, plz make sure the click area stays the same size as it is in the current version.

Comment 9

[Amir Nissim (:amirn)]

Attachment: clickable-area.png

bigger click area (see attachment)
updated PR

Comment 10

[Amir Nissim (:amirn)]

Attachment: clear-buttons-list.txt

Side notes:

1. the assets file does not include a @2x version. we had one before. do we really need it?
2. I have complied a list of clear buttons assets used in gaia (find . -name *clear*.png), maybe there are other assets that should be updated?

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

Amy, any reason not to trim the images to have no white space?

Comment 12

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/70fb206

Comment 13

[Amy Lee [:amylee] UX]

(In reply to Ran Ben Aharon (Everything.me) from comment #11)
> Amy, any reason not to trim the images to have no white space?

Hi Ran, 

Which images are you referring to?

Comment 14

[Amy Lee [:amylee] UX]

(In reply to Ran Ben Aharon (Everything.me) from comment #11)
> Amy, any reason not to trim the images to have no white space?

Hi Ran, 

Which images are you referring to?

Comment 15

[Amy Lee [:amylee] UX]

(In reply to Amir Nissim (Everything.me) from comment #10)
> Created attachment 8342955 [details]
> clear-buttons-list.txt
> 
> Side notes:
> 
> 1. the assets file does not include a @2x version. we had one before. do we
> really need it?
> 2. I have complied a list of clear buttons assets used in gaia (find . -name
> *clear*.png), maybe there are other assets that should be updated?

We are no longer supporting @2x graphics so these will not be needed. Thanks

Comment 16

[Amy Lee [:amylee] UX]

(In reply to Amy from comment #15)
> (In reply to Amir Nissim (Everything.me) from comment #10)
> > Created attachment 8342955 [details]
> > clear-buttons-list.txt
> > 
> > Side notes:
> > 
> > 1. the assets file does not include a @2x version. we had one before. do we
> > really need it?
> > 2. I have complied a list of clear buttons assets used in gaia (find . -name
> > *clear*.png), maybe there are other assets that should be updated?
> 
> We are no longer supporting @2x graphics so these will not be needed. Thanks

Hi Amir, 

I had attached "clear_icon_assets.zip" where there are screenshots of all the places we need to replace the "clear" icon in. Can you make sure your list covers the icons in the screens shots? Thanks

Comment 17

[Ran Ben Aharon [:ranbena] EverythingMe]

Hey Amy, we won't be able to do the other apps. We're on a very tight schedule as it is :/

Comment 18

[Amy Lee [:amylee] UX]

(In reply to Ran Ben Aharon (Everything.me) from comment #17)
> Hey Amy, we won't be able to do the other apps. We're on a very tight
> schedule as it is :/

Hey Ran, 

That's okay I had assigned the rest of the icon replacement to Pavel so we'll see if he has time to get them in. Thanks

Comment 19

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Amy,

is this still valid?

Comment 20

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #19)
> Hey Amy,
> 
> is this still valid?

Hi Pavel, 

It looks like the "x" icons have been updated to the correct ones now so the issue has been resolved. Thanks!

Comment 21

[Amy Lee [:amylee] UX]

Attachment: 2014-07-26-15-56-05.png

Hi Pavel, 

Just noticed that the "x" in the top search bar is using an outdated version.

Comment 22

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Comment 23

[Eric Pang [:epang] UX]

(In reply to Amy Lee [:amylee] from comment #21)
> Created attachment 8458750 [details]
> 2014-07-26-15-56-05.png
> 
> Hi Pavel, 
> 
> Just noticed that the "x" in the top search bar is using an outdated version.

Hey Amy, I used the styling of the 'x' from the music player search.  Is there a different one that should be used?

Comment 24

[Amy Lee [:amylee] UX]

(In reply to Eric Pang [:epang] from comment #23)
> (In reply to Amy Lee [:amylee] from comment #21)
> > Created attachment 8458750 [details]
> > 2014-07-26-15-56-05.png
> > 
> > Hi Pavel, 
> > 
> > Just noticed that the "x" in the top search bar is using an outdated version.
> 
> Hey Amy, I used the styling of the 'x' from the music player search.  Is
> there a different one that should be used?

Hi Pavel, 

The "x" in music looks different than the "x" in the search bar. The "x" in the music bar is the correct one. Eric, can you confirm? Or am I crazy?

Comment 25

[Eric Pang [:epang] UX]

Hey Guys, sorry for the confusion.  I used the clear icon from music in  the common controls - must be updated.  We should update the icon to use the same clear icon that music is currently using.

Comment 26

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Eric,
can you open a bug and assign it to me :) I will fix this asap :)

thanks :)

Comment 27

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #26)
> Eric,
> can you open a bug and assign it to me :) I will fix this asap :)
> 
> thanks :)

Opened bug 1045004 :)